Set per-monitor DPI awareness explicitly and verify picks on mixed-DPI desktops

Offen
#67 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 3 Tagen

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
35/100
Issue-Typ
Feature
Klarheit
Größtenteils klar
Aktivitätsstatus
Ruhig
Tech-Stack
python

Rechercherichtung

Start with the entry point that defines main(), autoclicker/gui/picker.py, and click_engine.py; inspect WindowsAutoclicker.spec and the DPI notes in docs/ARCHITECTURE.md and docs/PERFORMANCE.md. Verify the awareness call runs before Tk and PyAutoGUI load, then use the proposed unit test and manually check picked clicks on both monitors of a mixed-DPI Windows desktop. Done means per-monitor awareness is documented and each click lands on its picked pixel.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

bug maintenance priority: low

Why it matters

Picking and clicking only line up if the picker (Tk) and the clicker (PyAutoGUI / Win32) agree on what a pixel is. Today the process's DPI awareness is set implicitly, as a side effect of importing PyAutoGUI, and only to system awareness. On the setups where coordinate bugs actually happen (a 4K laptop at 150% next to a 1080p monitor at 100%), Windows virtualizes coordinates per monitor for system-aware apps. The result may be fine, slightly off, or a blurry overlay on one screen, and nothing in the repo verifies which.

Evidence

  • pyautogui/_pyautogui_win.py calls ctypes.windll.user32.SetProcessDPIAware() at import (system-aware, not per-monitor).
  • No SetProcessDpiAwarenessContext call and no manifest entry in WindowsAutoclicker.spec; nothing in autoclicker/ mentions DPI.
  • autoclicker/gui/picker.py sizes the overlay from GetSystemMetrics(SM_*VIRTUALSCREEN) and reports event.x_root/y_root; click_engine.py moves with pyautogui.moveTo. Correctness on mixed-DPI desktops depends on both sides being virtualized identically.
  • docs/PERFORMANCE.md and docs/ARCHITECTURE.md already list "multi-monitor DPI risk" as a reason to defer a SendInput path.

Suggested approach

  1. Set awareness explicitly and first thing in main() (before Tk and PyAutoGUI load): SetProcessDpiAwarenessContext(DPI_AWARENESS_CONTEXT_PER_MONITOR_AWARE_V2) with fallbacks to SetProcessDpiAwareness(2) and SetProcessDPIAware(). Optionally also embed it in the exe manifest.
  2. Manually verify on a mixed-DPI two-monitor setup: pick a point on each monitor, run, and confirm the click lands on the picked pixel. Record the result in docs/ARCHITECTURE.md.
  3. Add a unit test that main() calls the awareness setter before creating the app.

Done when

  • DPI awareness is explicit, per-monitor v2 where available, and documented.
  • Picks on every monitor of a mixed-DPI desktop click the exact picked pixel (verified once manually and noted in docs).
Vorherrschende Sprache
Python
Sterne
0
Forks
2
Ø Merge
2 T. 13 Std.
Gemergte PRs (30 T.)
2

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus TMHSDigital/autoclicker

Alle Issues in TMHSDigital/autoclicker

Ähnliche Issues

Weitere Issues zu Python

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.