One slow handler stalls the outbox, and each delivery queries the default locale

Open
#3,303 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
48/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
csharp
Domain
backend

Research direction

Start with src/FluentCMS.Core/Events/OutboxDrainer.cs and the worker registration in DependencyInjection/FluentCmsServiceCollectionExtensions.cs; the issue also names EventOperation.cs, JobExecutor.cs, OutboxKick.cs, and OutboxDrainJob.cs. Review the related job store behavior and coordinate with #3282, which changes the same drain. Done means meeting all five acceptance criteria and adding tests for each.

Written by the indexing model from the issue text.

Description

area:events performance type:bug

Problem

  1. One slow handler stalls every handler. The outbox queue has one worker (DependencyInjection/FluentCmsServiceCollectionExtensions.cs:285) and a drain delivers rows one at a time (Events/OutboxDrainer.cs:59-71), so a handler that takes the 60 s DeliveryTimeout holds back all the others.
  2. Each delivery and each job run queries the default locale. Events/EventOperation.cs:19-22 and Jobs/JobExecutor.cs:248-251 read Site.DefaultLocale uncached.
  3. A failed drain suppresses kicks. Events/OutboxKick.cs:24 treats any pending drain job as already queued without looking at RunAt. After a failure the retry is pending in the future (Jobs/JobStore.cs:153-154), so delivery falls back to the every-minute drain for about 7 minutes.
  4. The idle recurring drain writes rows every minute. Events/OutboxDrainJob.cs:103 inserts a job and an attempt row per minute, kept 7 days: about 10,000 of each on an idle instance.

Paths are under src/FluentCMS.Core/.

Proposal

  • Deliver in parallel per handler name, keeping order within a handler.
  • Read the default locale through the site cache.
  • Count only a drain job that is due as already queued.
  • Skip the bookkeeping of the recurring drain when nothing is due, or shorten its retention.

Done together with #3282, which changes the same drain.

Acceptance

  • A handler that blocks does not delay deliveries to other handlers
  • Order within one handler is unchanged
  • Delivering a batch reads the default locale once per site
  • A kick after a failed drain is delivered without waiting for the recurring drain
  • An idle instance does not accumulate drain rows
  • Tests for each

Found in the code review of 17 Nov 2026.

Dominant language
C#
Stars
569
Forks
107
Avg merge
2h 49m
Merged PRs (30d)
397

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from fluentcms/FluentCMS

All issues in fluentcms/FluentCMS

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.