One slow handler stalls the outbox, and each delivery queries the default locale

未关闭
#3,303 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
48/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
活跃
技术栈
csharp
领域
backend

调研方向

Start with src/FluentCMS.Core/Events/OutboxDrainer.cs and the worker registration in DependencyInjection/FluentCmsServiceCollectionExtensions.cs; the issue also names EventOperation.cs, JobExecutor.cs, OutboxKick.cs, and OutboxDrainJob.cs. Review the related job store behavior and coordinate with #3282, which changes the same drain. Done means meeting all five acceptance criteria and adding tests for each.

由索引模型根据 Issue 内容生成。

描述

area:events performance type:bug

Problem

  1. One slow handler stalls every handler. The outbox queue has one worker (DependencyInjection/FluentCmsServiceCollectionExtensions.cs:285) and a drain delivers rows one at a time (Events/OutboxDrainer.cs:59-71), so a handler that takes the 60 s DeliveryTimeout holds back all the others.
  2. Each delivery and each job run queries the default locale. Events/EventOperation.cs:19-22 and Jobs/JobExecutor.cs:248-251 read Site.DefaultLocale uncached.
  3. A failed drain suppresses kicks. Events/OutboxKick.cs:24 treats any pending drain job as already queued without looking at RunAt. After a failure the retry is pending in the future (Jobs/JobStore.cs:153-154), so delivery falls back to the every-minute drain for about 7 minutes.
  4. The idle recurring drain writes rows every minute. Events/OutboxDrainJob.cs:103 inserts a job and an attempt row per minute, kept 7 days: about 10,000 of each on an idle instance.

Paths are under src/FluentCMS.Core/.

Proposal

  • Deliver in parallel per handler name, keeping order within a handler.
  • Read the default locale through the site cache.
  • Count only a drain job that is due as already queued.
  • Skip the bookkeeping of the recurring drain when nothing is due, or shorten its retention.

Done together with #3282, which changes the same drain.

Acceptance

  • A handler that blocks does not delay deliveries to other handlers
  • Order within one handler is unchanged
  • Delivering a batch reads the default locale once per site
  • A kick after a failed drain is delivered without waiting for the recurring drain
  • An idle instance does not accumulate drain rows
  • Tests for each

Found in the code review of 17 Nov 2026.

主要语言
C#
星标
569
派生
107
平均合并
2 小时 49 分钟
30 天内合并 PR
397

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

fluentcms/FluentCMS 的其他 Issue

查看 fluentcms/FluentCMS 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。