One slow handler stalls the outbox, and each delivery queries the default locale

オープン
#3,303 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
48/100
issue の種類
機能追加
明瞭さ
おおむね明確
活発さ
活発
技術スタック
csharp
領域
backend

調査の方向性

Start with src/FluentCMS.Core/Events/OutboxDrainer.cs and the worker registration in DependencyInjection/FluentCmsServiceCollectionExtensions.cs; the issue also names EventOperation.cs, JobExecutor.cs, OutboxKick.cs, and OutboxDrainJob.cs. Review the related job store behavior and coordinate with #3282, which changes the same drain. Done means meeting all five acceptance criteria and adding tests for each.

索引モデルが issue の本文から書いたものです。

説明

area:events performance type:bug

Problem

  1. One slow handler stalls every handler. The outbox queue has one worker (DependencyInjection/FluentCmsServiceCollectionExtensions.cs:285) and a drain delivers rows one at a time (Events/OutboxDrainer.cs:59-71), so a handler that takes the 60 s DeliveryTimeout holds back all the others.
  2. Each delivery and each job run queries the default locale. Events/EventOperation.cs:19-22 and Jobs/JobExecutor.cs:248-251 read Site.DefaultLocale uncached.
  3. A failed drain suppresses kicks. Events/OutboxKick.cs:24 treats any pending drain job as already queued without looking at RunAt. After a failure the retry is pending in the future (Jobs/JobStore.cs:153-154), so delivery falls back to the every-minute drain for about 7 minutes.
  4. The idle recurring drain writes rows every minute. Events/OutboxDrainJob.cs:103 inserts a job and an attempt row per minute, kept 7 days: about 10,000 of each on an idle instance.

Paths are under src/FluentCMS.Core/.

Proposal

  • Deliver in parallel per handler name, keeping order within a handler.
  • Read the default locale through the site cache.
  • Count only a drain job that is due as already queued.
  • Skip the bookkeeping of the recurring drain when nothing is due, or shorten its retention.

Done together with #3282, which changes the same drain.

Acceptance

  • A handler that blocks does not delay deliveries to other handlers
  • Order within one handler is unchanged
  • Delivering a batch reads the default locale once per site
  • A kick after a failed drain is delivered without waiting for the recurring drain
  • An idle instance does not accumulate drain rows
  • Tests for each

Found in the code review of 17 Nov 2026.

主要言語
C#
スター
569
フォーク
107
平均マージ
2時間 49分
マージ済み PR(30日)
397

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

fluentcms/FluentCMS のほかの issue

fluentcms/FluentCMS の issue をすべて見る

似ている issue

C# の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。