AI Assist can send a key to another endpoint and has no budget; MCP unpublish needs no dry run

Open
#3,300 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
35/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Active
Tech stack
csharp

Research direction

Start with AiClientFactory.cs and AiAssistService.cs for endpoint binding and rate limiting, then inspect McpContentTools.cs and docs/planning/specification/09-ai-agents.md for unpublish dry runs. Trace how AiUsage is stored and queried before choosing where to enforce a per-site daily budget. Done means all four acceptance checks pass, with tests for each; the issue names no test files.

Written by the indexing model from the issue text.

Description

plugin security type:bug

Problem

  1. An AI key set by the operator can be sent to another allowed endpoint. src/plugins/FluentCMS.Plugins.AiAssist/AiClientFactory.cs:58-77 binds the OpenAI configuration key to its own endpoint, but not FluentCms:Ai:AzureOpenAi:ApiKey or OpenAiCompatible:ApiKey (:65). A site admin can point the site at any other entry of AllowedEndpoints and the key goes there.
  2. The rate limit is taken after the local work. AiAssistService.cs:185,199,213,216: the draft read, the image decode and resize for alt text, and client creation all run before the bucket is consumed.
  3. There is no cost budget. Limits today are CallsPerMinute in memory, MaxInputLength, MaxOutputTokens and RequestTimeout. Token usage is recorded in AiUsage for 90 days and never enforced.
  4. MCP unpublish takes live content down without a confirmed dry run. src/plugins/FluentCMS.Plugins.Mcp/McpContentTools.cs:429-451 call the content service directly, while {type}_delete and bulk go through McpDryRuns (:141, :499). docs/planning/specification/09-ai-agents.md:14 asks for dry runs on delete and bulk only.

Proposal

  • Apply the own-endpoint rule to the configuration key of every provider.
  • Check the bucket after the permission checks and consume it just before sending.
  • Add a daily token budget per site (off by default), summed from AiUsage before a call.
  • Route unpublish through the dry-run plan and token; publish stays direct. Update the specification line.

Acceptance

  • A configuration key is never sent to an endpoint other than the one it was configured for
  • A caller over the limit is refused before the draft is read or an image decoded
  • A site over its daily budget is refused with a problem that says when it resets
  • MCP unpublish without a valid confirmation token returns the plan and changes nothing
  • Tests for each

Found in the code review of 17 Nov 2026.

Dominant language
C#
Stars
569
Forks
107
Avg merge
2h 49m
Merged PRs (30d)
397

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from fluentcms/FluentCMS

All issues in fluentcms/FluentCMS

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.