AI Assist can send a key to another endpoint and has no budget; MCP unpublish needs no dry run

未关闭
#3,300 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
35/100
Issue 类型
功能
描述清晰度
描述清楚
活跃度
活跃
技术栈
csharp

调研方向

Start with AiClientFactory.cs and AiAssistService.cs for endpoint binding and rate limiting, then inspect McpContentTools.cs and docs/planning/specification/09-ai-agents.md for unpublish dry runs. Trace how AiUsage is stored and queried before choosing where to enforce a per-site daily budget. Done means all four acceptance checks pass, with tests for each; the issue names no test files.

由索引模型根据 Issue 内容生成。

描述

plugin security type:bug

Problem

  1. An AI key set by the operator can be sent to another allowed endpoint. src/plugins/FluentCMS.Plugins.AiAssist/AiClientFactory.cs:58-77 binds the OpenAI configuration key to its own endpoint, but not FluentCms:Ai:AzureOpenAi:ApiKey or OpenAiCompatible:ApiKey (:65). A site admin can point the site at any other entry of AllowedEndpoints and the key goes there.
  2. The rate limit is taken after the local work. AiAssistService.cs:185,199,213,216: the draft read, the image decode and resize for alt text, and client creation all run before the bucket is consumed.
  3. There is no cost budget. Limits today are CallsPerMinute in memory, MaxInputLength, MaxOutputTokens and RequestTimeout. Token usage is recorded in AiUsage for 90 days and never enforced.
  4. MCP unpublish takes live content down without a confirmed dry run. src/plugins/FluentCMS.Plugins.Mcp/McpContentTools.cs:429-451 call the content service directly, while {type}_delete and bulk go through McpDryRuns (:141, :499). docs/planning/specification/09-ai-agents.md:14 asks for dry runs on delete and bulk only.

Proposal

  • Apply the own-endpoint rule to the configuration key of every provider.
  • Check the bucket after the permission checks and consume it just before sending.
  • Add a daily token budget per site (off by default), summed from AiUsage before a call.
  • Route unpublish through the dry-run plan and token; publish stays direct. Update the specification line.

Acceptance

  • A configuration key is never sent to an endpoint other than the one it was configured for
  • A caller over the limit is refused before the draft is read or an image decoded
  • A site over its daily budget is refused with a problem that says when it resets
  • MCP unpublish without a valid confirmation token returns the plan and changes nothing
  • Tests for each

Found in the code review of 17 Nov 2026.

主要语言
C#
星标
569
派生
107
平均合并
2 小时 49 分钟
30 天内合并 PR
397

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

fluentcms/FluentCMS 的其他 Issue

查看 fluentcms/FluentCMS 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。