AI Assist can send a key to another endpoint and has no budget; MCP unpublish needs no dry run

オープン
#3,300 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
5/5
見積もり時間
1週間以上
初心者へのやさしさ
35/100
issue の種類
機能追加
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
csharp

調査の方向性

Start with AiClientFactory.cs and AiAssistService.cs for endpoint binding and rate limiting, then inspect McpContentTools.cs and docs/planning/specification/09-ai-agents.md for unpublish dry runs. Trace how AiUsage is stored and queried before choosing where to enforce a per-site daily budget. Done means all four acceptance checks pass, with tests for each; the issue names no test files.

索引モデルが issue の本文から書いたものです。

説明

plugin security type:bug

Problem

  1. An AI key set by the operator can be sent to another allowed endpoint. src/plugins/FluentCMS.Plugins.AiAssist/AiClientFactory.cs:58-77 binds the OpenAI configuration key to its own endpoint, but not FluentCms:Ai:AzureOpenAi:ApiKey or OpenAiCompatible:ApiKey (:65). A site admin can point the site at any other entry of AllowedEndpoints and the key goes there.
  2. The rate limit is taken after the local work. AiAssistService.cs:185,199,213,216: the draft read, the image decode and resize for alt text, and client creation all run before the bucket is consumed.
  3. There is no cost budget. Limits today are CallsPerMinute in memory, MaxInputLength, MaxOutputTokens and RequestTimeout. Token usage is recorded in AiUsage for 90 days and never enforced.
  4. MCP unpublish takes live content down without a confirmed dry run. src/plugins/FluentCMS.Plugins.Mcp/McpContentTools.cs:429-451 call the content service directly, while {type}_delete and bulk go through McpDryRuns (:141, :499). docs/planning/specification/09-ai-agents.md:14 asks for dry runs on delete and bulk only.

Proposal

  • Apply the own-endpoint rule to the configuration key of every provider.
  • Check the bucket after the permission checks and consume it just before sending.
  • Add a daily token budget per site (off by default), summed from AiUsage before a call.
  • Route unpublish through the dry-run plan and token; publish stays direct. Update the specification line.

Acceptance

  • A configuration key is never sent to an endpoint other than the one it was configured for
  • A caller over the limit is refused before the draft is read or an image decoded
  • A site over its daily budget is refused with a problem that says when it resets
  • MCP unpublish without a valid confirmation token returns the plan and changes nothing
  • Tests for each

Found in the code review of 17 Nov 2026.

主要言語
C#
スター
569
フォーク
107
平均マージ
2時間 49分
マージ済み PR(30日)
397

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

fluentcms/FluentCMS のほかの issue

fluentcms/FluentCMS の issue をすべて見る

似ている issue

C# の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。