A webhook sends its stored secret headers to a changed URL, and a NUL byte in an answer repeats the delivery
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 55/100
Research direction
Start with WebhookService.cs around lines 139, 353, and 424 to trace how masked headers are retained when a URL changes. Then read WebhookSender.cs around lines 96–107 and WebhookDeliveryJob.cs around lines 68–78 and 186–207 to follow answer storage and retry handling. Add regression tests for both acceptance cases and verify that a 2xx response containing a NUL byte is recorded as one successful delivery across providers.
Written by the indexing model from the issue text.
Description
Problem
- A kept
***header follows a changed URL.src/plugins/FluentCMS.Plugins.Webhooks/WebhookService.cs:139,353keep the stored value for a header sent as***without checking that the URL is unchanged (applied at:424). Awebhooks.manageholder can repoint the webhook to a host of their own and receive headers that are write-only. - An answer containing a NUL byte is delivered six times and dead-lettered on PostgreSQL.
WebhookSender.cs:96-107stores up to 4 KB of the answer as received, andWebhookDeliveryJob.cs:68-78writes it to a text column, which PostgreSQL refuses for0x00. The job throws after a 2xx,TakeOverAsync(:186-207) marks the attempt interrupted and schedules the next. The receiver gets duplicates, aWebhookDeadEventis raised, and the webhook is disabled whenDisableAfteris set. This was read from the code, not reproduced.
Proposal
- Refuse
***when the scheme, host or port of the URL changes; the caller must send the value again. - Strip control characters from the stored excerpt.
Done together with #3268, which changes the same delivery job.
Acceptance
- An update that changes the host and keeps a header as
***is refused with a problem naming the header - The same update with the URL unchanged, or only its path changed, keeps the header
- A 2xx answer containing
0x00is recorded as one successful delivery on every provider - Tests for each, failing before the fix
Found in the code review of 17 Nov 2026.
- Dominant language
- C#
- Stars
- 569
- Forks
- 107
- Avg merge
- 2h 49m
- Merged PRs (30d)
- 397
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from fluentcms/FluentCMS
-
area:host area:operations type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
area:build security type:chore
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
area:sdk security type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
area:content security type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
area:build type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
All issues in fluentcms/FluentCMS
Similar issues
-
bug needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
microsoft/microsoft-ui-reactor#1567 ·
Maintainers usually reply within 1 day
-
clawsweeper:fix-shape-clear clawsweeper:queueable-fix clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster no-stale P2
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
openclaw/openclaw-windows-node#2287 · 2 comments · 1 reaction ·
Maintainers usually reply within 1 day
-
kind:ux needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
elsa-workflows/elsa-foundation#4742 ·
Maintainers usually reply within 1 day
-
priority:P2
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
enhancement good first issue help wanted new-language
Difficulty 2/5 1-3 hours Newbie friendliness 82/100