A webhook sends its stored secret headers to a changed URL, and a NUL byte in an answer repeats the delivery
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 55/100
调研方向
Start with WebhookService.cs around lines 139, 353, and 424 to trace how masked headers are retained when a URL changes. Then read WebhookSender.cs around lines 96–107 and WebhookDeliveryJob.cs around lines 68–78 and 186–207 to follow answer storage and retry handling. Add regression tests for both acceptance cases and verify that a 2xx response containing a NUL byte is recorded as one successful delivery across providers.
由索引模型根据 Issue 内容生成。
描述
Problem
- A kept
***header follows a changed URL.src/plugins/FluentCMS.Plugins.Webhooks/WebhookService.cs:139,353keep the stored value for a header sent as***without checking that the URL is unchanged (applied at:424). Awebhooks.manageholder can repoint the webhook to a host of their own and receive headers that are write-only. - An answer containing a NUL byte is delivered six times and dead-lettered on PostgreSQL.
WebhookSender.cs:96-107stores up to 4 KB of the answer as received, andWebhookDeliveryJob.cs:68-78writes it to a text column, which PostgreSQL refuses for0x00. The job throws after a 2xx,TakeOverAsync(:186-207) marks the attempt interrupted and schedules the next. The receiver gets duplicates, aWebhookDeadEventis raised, and the webhook is disabled whenDisableAfteris set. This was read from the code, not reproduced.
Proposal
- Refuse
***when the scheme, host or port of the URL changes; the caller must send the value again. - Strip control characters from the stored excerpt.
Done together with #3268, which changes the same delivery job.
Acceptance
- An update that changes the host and keeps a header as
***is refused with a problem naming the header - The same update with the URL unchanged, or only its path changed, keeps the header
- A 2xx answer containing
0x00is recorded as one successful delivery on every provider - Tests for each, failing before the fix
Found in the code review of 17 Nov 2026.
- 主要语言
- C#
- 星标
- 569
- 派生
- 107
- 平均合并
- 2 小时 49 分钟
- 30 天内合并 PR
- 397
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
fluentcms/FluentCMS 的其他 Issue
-
area:host area:operations type:bug
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
area:build security type:chore
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
area:sdk security type:bug
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
area:content security type:bug
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
area:build type:bug
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
查看 fluentcms/FluentCMS 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 75/100
维护者通常 1 天内回复
-
bug needs-triage
难度 2/5 1-3 小时 新手友好度 67/100
microsoft/microsoft-ui-reactor#1567 ·
维护者通常 1 天内回复
-
clawsweeper:fix-shape-clear clawsweeper:queueable-fix clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster no-stale P2
难度 2/5 1-3 小时 新手友好度 76/100
openclaw/openclaw-windows-node#2287 · 2 条评论 · 1 个 reaction ·
维护者通常 1 天内回复
-
kind:ux needs-triage
难度 2/5 1-3 小时 新手友好度 66/100
elsa-workflows/elsa-foundation#4742 ·
维护者通常 1 天内回复
-
priority:P2
难度 2/5 1-3 小时 新手友好度 88/100