A webhook sends its stored secret headers to a changed URL, and a NUL byte in an answer repeats the delivery
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 55/100
Línea de trabajo
Start with WebhookService.cs around lines 139, 353, and 424 to trace how masked headers are retained when a URL changes. Then read WebhookSender.cs around lines 96–107 and WebhookDeliveryJob.cs around lines 68–78 and 186–207 to follow answer storage and retry handling. Add regression tests for both acceptance cases and verify that a 2xx response containing a NUL byte is recorded as one successful delivery across providers.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Problem
- A kept
***header follows a changed URL.src/plugins/FluentCMS.Plugins.Webhooks/WebhookService.cs:139,353keep the stored value for a header sent as***without checking that the URL is unchanged (applied at:424). Awebhooks.manageholder can repoint the webhook to a host of their own and receive headers that are write-only. - An answer containing a NUL byte is delivered six times and dead-lettered on PostgreSQL.
WebhookSender.cs:96-107stores up to 4 KB of the answer as received, andWebhookDeliveryJob.cs:68-78writes it to a text column, which PostgreSQL refuses for0x00. The job throws after a 2xx,TakeOverAsync(:186-207) marks the attempt interrupted and schedules the next. The receiver gets duplicates, aWebhookDeadEventis raised, and the webhook is disabled whenDisableAfteris set. This was read from the code, not reproduced.
Proposal
- Refuse
***when the scheme, host or port of the URL changes; the caller must send the value again. - Strip control characters from the stored excerpt.
Done together with #3268, which changes the same delivery job.
Acceptance
- An update that changes the host and keeps a header as
***is refused with a problem naming the header - The same update with the URL unchanged, or only its path changed, keeps the header
- A 2xx answer containing
0x00is recorded as one successful delivery on every provider - Tests for each, failing before the fix
Found in the code review of 17 Nov 2026.
- Lenguaje dominante
- C#
- Estrellas
- 569
- Forks
- 107
- Merge medio
- 2 h 49 min
- PR fusionados (30 d)
- 397
Preparar el entorno
- Incluye un Dockerfile o un archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de fluentcms/FluentCMS
-
area:host area:operations type:bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
Los mantenedores suelen responder en 1 día
-
area:build security type:chore
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
Los mantenedores suelen responder en 1 día
-
area:sdk security type:bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
Los mantenedores suelen responder en 1 día
-
area:content security type:bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
Los mantenedores suelen responder en 1 día
-
area:build type:bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
Los mantenedores suelen responder en 1 día
Todos los issues de fluentcms/FluentCMS
Issues similares
-
bug needs-triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 67/100
microsoft/microsoft-ui-reactor#1567 ·
Los mantenedores suelen responder en 1 día
-
clawsweeper:fix-shape-clear clawsweeper:queueable-fix clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster no-stale P2
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
openclaw/openclaw-windows-node#2287 · 2 comentarios · 1 reacción ·
Los mantenedores suelen responder en 1 día
-
kind:ux needs-triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 66/100
elsa-workflows/elsa-foundation#4742 ·
Los mantenedores suelen responder en 1 día
-
priority:P2
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
-
[LANG] Add support for C# (.cs)Abiertoenhancement good first issue help wanted new-language
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100