Admin passwords and authenticator codes miss lockout, replay and forced-change checks
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 48/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- csharp
- Domain
- authentication, backend, security
Research direction
Start by reading the six referenced paths under src/FluentCMS.Core/, especially the admin sign-in, two-factor and refresh flows, and compare the lockout handling with Identity/Members/MemberAccountService.cs:178-196. Then inspect the related tests and add failing coverage for each acceptance item. Done means all six behaviors are fixed and their tests pass; coordinate with #3271 because it changes the same lockout path.
Written by the indexing model from the issue text.
Description
Problem
Six gaps in how the admin pool handles passwords and second factors, all in the same sign-in code.
- Change password does not count failures.
Api/Account/ChangePasswordModel.cs:41callsChangePasswordAsync;Identity/CmsUserManager.cs:219adds noAccessFailedAsyncor lockout check. A hijacked cookie can guess the current password, bounded only by the per-addressauthlimit. The member pool counts them (Identity/Members/MemberAccountService.cs:178-196). - Authenticator codes can be replayed inside their window. The stock
AuthenticatorTokenProvider<CmsUser>(Identity/IdentityRegistration.cs:39) is used atIdentity/TwoFactorService.cs:126andApi/Account/TwoFactorModel.cs:47with no record of the last accepted time step. - A user name can equal the email of another user. Only
RequireUniqueEmailis set (Identity/AdminUserOptions.cs:53). Sign-in resolves the user name first (Identity/CmsSignInManager.cs:135-136), and an invitee picks the name (Identity/InvitationService.cs:215). The sign-in of the email's owner then lands on the other account and counts toward its lockout. - Enabling 2FA drops the sign-on method.
Api/Account/EnableTwoFactorModel.cs:81-82re-signs with onlyamr=mfa, losingamr=pwdand the provider claim. Nothing reads them today, so tokens only carry a wrongamr. mustChangePasswordis not enforced on refresh. It is checked at authorize (Identity/Oidc/ConnectEndpoints.cs:136) but not in the refresh branch (:181-256), and setting the flag changes no security stamp (Identity/UserAdministration.cs:143-152). Existing sessions keep refreshing untilAbsoluteSessionLifetime.- CLI
user set-passwordclearsMustChangePassword.UserAdministration.cs:109-116goes throughResetPasswordAsync, whichCmsUserManager.cs:222-223,239-252treats as a change by the user.
Paths are under src/FluentCMS.Core/.
Proposal
- Count a wrong current password toward lockout, as the member pool does.
- Store the last accepted time step per user and refuse a code at or before it.
- Add an
IUserValidatorthat refuses a name equal to the normalized email of another user. - Carry the existing method claims over when 2FA is enabled, as
KeepAuthenticationMethodsdoes (Identity/Oidc/AuthorizationServerRegistration.cs:171-179). - Refuse refresh with
invalid_grantwhile the flag is set. - Keep or set the flag after an operator sets a password.
Done together with #3271, which changes the same lockout path.
Acceptance
- Wrong current passwords on change-password lock the account at the configured count
- The same authenticator code is refused the second time, at sign-in and at enrolment
- Creating, inviting or renaming a user to a name equal to the email of another user is refused
- A session keeps its sign-on method after enabling 2FA
- A flagged user cannot refresh a token
-
user set-passwordleaves the user flagged to change it - Tests for each, failing before the fix
Found in the code review of 17 Nov 2026.
- Dominant language
- C#
- Stars
- 569
- Forks
- 107
- Avg merge
- 2h 49m
- Merged PRs (30d)
- 397
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from fluentcms/FluentCMS
-
area:host area:operations type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
area:build security type:chore
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
area:sdk security type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
area:content security type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
area:build type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
All issues in fluentcms/FluentCMS
Similar issues
-
bug needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
microsoft/microsoft-ui-reactor#1567 ·
Maintainers usually reply within 1 day
-
clawsweeper:fix-shape-clear clawsweeper:queueable-fix clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster no-stale P2
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
openclaw/openclaw-windows-node#2287 · 2 comments · 1 reaction ·
Maintainers usually reply within 1 day
-
kind:ux needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
elsa-workflows/elsa-foundation#4742 ·
Maintainers usually reply within 1 day
-
priority:P2
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
enhancement good first issue help wanted new-language
Difficulty 2/5 1-3 hours Newbie friendliness 82/100