Admin passwords and authenticator codes miss lockout, replay and forced-change checks
Les mainteneurs répondent en général sous 1 jour
Personne n'a encore pris cette issue.
Évaluation
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Accessibilité débutants
- 48/100
- Type d'issue
- Bug
- Clarté
- Clairement spécifiée
- Activité
- Active
- Stack technique
- csharp
- Domaine
- authentication, backend, security
Piste de recherche
Start by reading the six referenced paths under src/FluentCMS.Core/, especially the admin sign-in, two-factor and refresh flows, and compare the lockout handling with Identity/Members/MemberAccountService.cs:178-196. Then inspect the related tests and add failing coverage for each acceptance item. Done means all six behaviors are fixed and their tests pass; coordinate with #3271 because it changes the same lockout path.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Description
Problem
Six gaps in how the admin pool handles passwords and second factors, all in the same sign-in code.
- Change password does not count failures.
Api/Account/ChangePasswordModel.cs:41callsChangePasswordAsync;Identity/CmsUserManager.cs:219adds noAccessFailedAsyncor lockout check. A hijacked cookie can guess the current password, bounded only by the per-addressauthlimit. The member pool counts them (Identity/Members/MemberAccountService.cs:178-196). - Authenticator codes can be replayed inside their window. The stock
AuthenticatorTokenProvider<CmsUser>(Identity/IdentityRegistration.cs:39) is used atIdentity/TwoFactorService.cs:126andApi/Account/TwoFactorModel.cs:47with no record of the last accepted time step. - A user name can equal the email of another user. Only
RequireUniqueEmailis set (Identity/AdminUserOptions.cs:53). Sign-in resolves the user name first (Identity/CmsSignInManager.cs:135-136), and an invitee picks the name (Identity/InvitationService.cs:215). The sign-in of the email's owner then lands on the other account and counts toward its lockout. - Enabling 2FA drops the sign-on method.
Api/Account/EnableTwoFactorModel.cs:81-82re-signs with onlyamr=mfa, losingamr=pwdand the provider claim. Nothing reads them today, so tokens only carry a wrongamr. mustChangePasswordis not enforced on refresh. It is checked at authorize (Identity/Oidc/ConnectEndpoints.cs:136) but not in the refresh branch (:181-256), and setting the flag changes no security stamp (Identity/UserAdministration.cs:143-152). Existing sessions keep refreshing untilAbsoluteSessionLifetime.- CLI
user set-passwordclearsMustChangePassword.UserAdministration.cs:109-116goes throughResetPasswordAsync, whichCmsUserManager.cs:222-223,239-252treats as a change by the user.
Paths are under src/FluentCMS.Core/.
Proposal
- Count a wrong current password toward lockout, as the member pool does.
- Store the last accepted time step per user and refuse a code at or before it.
- Add an
IUserValidatorthat refuses a name equal to the normalized email of another user. - Carry the existing method claims over when 2FA is enabled, as
KeepAuthenticationMethodsdoes (Identity/Oidc/AuthorizationServerRegistration.cs:171-179). - Refuse refresh with
invalid_grantwhile the flag is set. - Keep or set the flag after an operator sets a password.
Done together with #3271, which changes the same lockout path.
Acceptance
- Wrong current passwords on change-password lock the account at the configured count
- The same authenticator code is refused the second time, at sign-in and at enrolment
- Creating, inviting or renaming a user to a name equal to the email of another user is refused
- A session keeps its sign-on method after enabling 2FA
- A flagged user cannot refresh a token
-
user set-passwordleaves the user flagged to change it - Tests for each, failing before the fix
Found in the code review of 17 Nov 2026.
- Langage dominant
- C#
- Étoiles
- 569
- Forks
- 107
- Merge moyen
- 2 h 49 min
- PR mergées (30 j)
- 397
Préparer son environnement
- Fournit un Dockerfile ou un fichier Docker Compose
- Propose un modèle de pull request
- Lire le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Autres issues de fluentcms/FluentCMS
-
area:host area:operations type:bug
Difficulté 2/5 1-3 heures Accessibilité débutants 78/100
Les mainteneurs répondent en général sous 1 jour
-
area:build security type:chore
Difficulté 2/5 1-3 heures Accessibilité débutants 78/100
Les mainteneurs répondent en général sous 1 jour
-
area:sdk security type:bug
Difficulté 2/5 1-3 heures Accessibilité débutants 78/100
Les mainteneurs répondent en général sous 1 jour
-
area:content security type:bug
Difficulté 2/5 1-3 heures Accessibilité débutants 82/100
Les mainteneurs répondent en général sous 1 jour
-
area:build type:bug
Difficulté 2/5 1-3 heures Accessibilité débutants 78/100
Les mainteneurs répondent en général sous 1 jour
Toutes les issues de fluentcms/FluentCMS
Issues similaires
-
Difficulté 2/5 1-3 heures Accessibilité débutants 75/100
Les mainteneurs répondent en général sous 1 jour
-
bug needs-triage
Difficulté 2/5 1-3 heures Accessibilité débutants 67/100
microsoft/microsoft-ui-reactor#1567 ·
Les mainteneurs répondent en général sous 1 jour
-
clawsweeper:fix-shape-clear clawsweeper:queueable-fix clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster no-stale P2
Difficulté 2/5 1-3 heures Accessibilité débutants 76/100
openclaw/openclaw-windows-node#2287 · 2 commentaires · 1 réaction ·
Les mainteneurs répondent en général sous 1 jour
-
kind:ux needs-triage
Difficulté 2/5 1-3 heures Accessibilité débutants 66/100
elsa-workflows/elsa-foundation#4742 ·
Les mainteneurs répondent en général sous 1 jour
-
priority:P2
Difficulté 2/5 1-3 heures Accessibilité débutants 88/100