Admin passwords and authenticator codes miss lockout, replay and forced-change checks

Aberta
#3,296 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
48/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
csharp

Direção de pesquisa

Start by reading the six referenced paths under src/FluentCMS.Core/, especially the admin sign-in, two-factor and refresh flows, and compare the lockout handling with Identity/Members/MemberAccountService.cs:178-196. Then inspect the related tests and add failing coverage for each acceptance item. Done means all six behaviors are fixed and their tests pass; coordinate with #3271 because it changes the same lockout path.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

area:identity security type:bug

Problem

Six gaps in how the admin pool handles passwords and second factors, all in the same sign-in code.

  1. Change password does not count failures. Api/Account/ChangePasswordModel.cs:41 calls ChangePasswordAsync; Identity/CmsUserManager.cs:219 adds no AccessFailedAsync or lockout check. A hijacked cookie can guess the current password, bounded only by the per-address auth limit. The member pool counts them (Identity/Members/MemberAccountService.cs:178-196).
  2. Authenticator codes can be replayed inside their window. The stock AuthenticatorTokenProvider<CmsUser> (Identity/IdentityRegistration.cs:39) is used at Identity/TwoFactorService.cs:126 and Api/Account/TwoFactorModel.cs:47 with no record of the last accepted time step.
  3. A user name can equal the email of another user. Only RequireUniqueEmail is set (Identity/AdminUserOptions.cs:53). Sign-in resolves the user name first (Identity/CmsSignInManager.cs:135-136), and an invitee picks the name (Identity/InvitationService.cs:215). The sign-in of the email's owner then lands on the other account and counts toward its lockout.
  4. Enabling 2FA drops the sign-on method. Api/Account/EnableTwoFactorModel.cs:81-82 re-signs with only amr=mfa, losing amr=pwd and the provider claim. Nothing reads them today, so tokens only carry a wrong amr.
  5. mustChangePassword is not enforced on refresh. It is checked at authorize (Identity/Oidc/ConnectEndpoints.cs:136) but not in the refresh branch (:181-256), and setting the flag changes no security stamp (Identity/UserAdministration.cs:143-152). Existing sessions keep refreshing until AbsoluteSessionLifetime.
  6. CLI user set-password clears MustChangePassword. UserAdministration.cs:109-116 goes through ResetPasswordAsync, which CmsUserManager.cs:222-223,239-252 treats as a change by the user.

Paths are under src/FluentCMS.Core/.

Proposal

  • Count a wrong current password toward lockout, as the member pool does.
  • Store the last accepted time step per user and refuse a code at or before it.
  • Add an IUserValidator that refuses a name equal to the normalized email of another user.
  • Carry the existing method claims over when 2FA is enabled, as KeepAuthenticationMethods does (Identity/Oidc/AuthorizationServerRegistration.cs:171-179).
  • Refuse refresh with invalid_grant while the flag is set.
  • Keep or set the flag after an operator sets a password.

Done together with #3271, which changes the same lockout path.

Acceptance

  • Wrong current passwords on change-password lock the account at the configured count
  • The same authenticator code is refused the second time, at sign-in and at enrolment
  • Creating, inviting or renaming a user to a name equal to the email of another user is refused
  • A session keeps its sign-on method after enabling 2FA
  • A flagged user cannot refresh a token
  • user set-password leaves the user flagged to change it
  • Tests for each, failing before the fix

Found in the code review of 17 Nov 2026.

Linguagem predominante
C#
Estrelas
569
Forks
107
Merge médio
2h 49min
PRs com merge (30d)
397

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de fluentcms/FluentCMS

Todas as issues de fluentcms/FluentCMS

Issues semelhantes

Mais issues de C#

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.