Functions that take a `std::string_view` but construct a `std::string` internally should just take a `std::string const&`
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
The issue names no files, tests, or entry points. Search the SDK for functions accepting std::string_view that construct std::string internally, then determine the complete set of affected call sites and bindings. Done means those signatures use std::string const& where appropriate and the relevant build or tests still pass.
Written by the indexing model from the issue text.
Description
This will avoid incurring additional allocations at the binding boundaries
- Dominant language
- C++
- Stars
- 9
- Forks
- 2
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from fastly/compute-sdk-cpp
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
fastly/compute-sdk-cpp#90 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
fastly/compute-sdk-cpp#87 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
fastly/compute-sdk-cpp#88 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
fastly/compute-sdk-cpp#86 ·
-
documentation
Difficulty 4/5 3-5 days Newbie friendliness 30/100
fastly/compute-sdk-cpp#80 ·
All issues in fastly/compute-sdk-cpp
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
cp-algorithms/cp-algorithms#1715 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Icinga/icinga2#11058 · 1 comment ·
Maintainers usually reply within 1 day
-
status:needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
PX4/PX4-Autopilot#28924 ·
Maintainers usually reply within 1 day
-
component: split-view platform: windows
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
zen-browser/desktop#15616 · 1 reaction ·
Maintainers usually reply within 1 day