fastly::log::Endpoint doesn't implement the <iostream> interfaces.
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 55/100
Research direction
Start with include/fastly/log.h at the Endpoint declaration and src/cpp/log.cpp at from_name(). Compare the documented iostream usage with the class interface and its expectedfastly::log::Endpoint return type. Done means Endpoint supports the intended output interface and the documentation matches the actual return value.
Written by the indexing model from the issue text.
Description
I've noticed that while the code comment for fastly::log::Endpoint says I should write to the endpoint using the <iostream> interfaces, the code for the class doesn't actually implement std::ostream.
So currently it seems there is no way to output to an Endpoint instantiated using fastly::log::Endpoint::from_name().
Note this class doesn't inherit from anything:
https://github.com/fastly/compute-sdk-cpp/blob/57984bce76d17622a44eea286500497e201f7f71/include/fastly/log.h#L417-L425
Additionally, the code comment above shows fastly::log::Endpoint::from_name() being used as though it returns an fastly::log::Endpoint instance directly, but the actual SDK returns expected<fastly::log::Endpoint>.
- Dominant language
- C++
- Stars
- 9
- Forks
- 2
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from fastly/compute-sdk-cpp
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
fastly/compute-sdk-cpp#90 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
fastly/compute-sdk-cpp#87 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
fastly/compute-sdk-cpp#88 ·
-
documentation
Difficulty 4/5 3-5 days Newbie friendliness 30/100
fastly/compute-sdk-cpp#80 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 38/100
fastly/compute-sdk-cpp#74 ·
All issues in fastly/compute-sdk-cpp
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
AXERA-TECH/ax-llm#77 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
games-on-whales/wolf#509 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
bug-unconfirmed
Difficulty 2/5 1-3 hours Newbie friendliness 76/100