Fragmentation: add truncated fragment frames to the malformed sequences
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 92/100
- Issue type
- Documentation
- Clarity
- Clearly specified
- Activity status
- Active
- Domain
- documentation
Research direction
Open messaging.md and find the Fragmentation section's list of malformed sequences. Review the referenced handling in noise/wire.py for context, then add the two missing truncated-fragment cases described in the issue. Done means the list explicitly covers missing flags and missing orig_type bytes.
Written by the indexing model from the issue text.
Description
The list of malformed sequences under messaging.md "Fragmentation" is presented as exhaustive, but it doesn't cover a fragment frame that is too short to parse:
- any fragment with no
flagsbyte (plaintext is just[1]) - a first fragment with no
orig_typebyte (plaintext is[1][flags]with bit 1 set)
The receiver can't start reassembly for either one. aiosendspin (noise/wire.py) and sendspin-cpp both already close the connection for these.
Suggested fix: Add "a fragment missing its flags byte, or a first fragment missing its orig_type byte" to the list of malformed sequences.
- Dominant language
- Python
- Stars
- 126
- Forks
- 10
- Avg merge
- 19h 17m
- Merged PRs (30d)
- 78
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Sendspin/spec
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Sendspin/spec#145 · 2 comments ·
Maintainers usually reply within 1 day
-
Include time filter into the specificationPossibly taken @maximmaxim345 claimed this today. Open
Sendspin/spec#293 · 1 assignee ·
Maintainers usually reply within 1 day
-
bug
Difficulty 5/5 Over a week Newbie friendliness 35/100
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 28/100
Sendspin/spec#205 · 1 comment ·
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
letsencrypt/cp-cps#353 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
PedestrianDynamics/pyFDS-Evac#394 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
DOI-USGS/pywatershed#421 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
python-pillow/Pillow#10087 · 1 comment ·
Maintainers usually reply within 1 day