Windowing System: Improvement Ideas

Open
#1,600 4 comments 0 reactions 1 assignee View on GitHub

@SleeplessByte is already working on this.

Since Feb 7, 2022.

Assessment

This issue has not been assessed yet.

Description

discussion :speech_balloon:

After seeing a couple of solutions to "Windowing System" during mentoring, I think the exercise could need some changes to better achieve it's learning objectives.

  • For Position and Size, the constructor and the method have the same implementation. I saw a solution that used the method in the constructor which is not a very typical example.
  • There is no reason to use the methods to update values so students often just set the property values directly.
  • The calculation for the window resize and move is rather involved which does not add value for the actual learning objectives but it seems students spend quite some time finding creative solutions there, e.g.
    image

Some ideas how to improve the exercise:

  • Maybe we should expect some/all properties to be marked as private with the underscore to discourage the direct assignment. That might also make it easier to pick up unwanted code with the analyzer later. (Not sure how to best test in this case though. Either the test disrespects the underscore which is not a good example or the test needs to fall back on some user-implemented serialization function. But if that function is wrong all the tests will fail which is also annoying as everything else the user did could be correct.)
  • The methods on Position and Size could change the values by some amount instead of just setting a value. That would make them distinct from the constructor. (Probably only needed if we stick with "public properties".)
  • Simplify the window resize/move method e.g. by saying some lower bound is always respected
Dominant language
JavaScript
Stars
658
Forks
665
Avg merge
19h 32m
Merged PRs (30d)
5

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from exercism/javascript

All issues in exercism/javascript

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.