Windowing System: Improvement Ideas
@SleeplessByte is already working on this.
Since Feb 7, 2022.
Assessment
This issue has not been assessed yet.
Description
After seeing a couple of solutions to "Windowing System" during mentoring, I think the exercise could need some changes to better achieve it's learning objectives.
- For
PositionandSize, the constructor and the method have the same implementation. I saw a solution that used the method in the constructor which is not a very typical example. - There is no reason to use the methods to update values so students often just set the property values directly.
- The calculation for the window resize and move is rather involved which does not add value for the actual learning objectives but it seems students spend quite some time finding creative solutions there, e.g.

Some ideas how to improve the exercise:
- Maybe we should expect some/all properties to be marked as private with the underscore to discourage the direct assignment. That might also make it easier to pick up unwanted code with the analyzer later. (Not sure how to best test in this case though. Either the test disrespects the underscore which is not a good example or the test needs to fall back on some user-implemented serialization function. But if that function is wrong all the tests will fail which is also annoying as everything else the user did could be correct.)
- The methods on
PositionandSizecould change the values by some amount instead of just setting a value. That would make them distinct from the constructor. (Probably only needed if we stick with "public properties".) - Simplify the window resize/move method e.g. by saying some lower bound is always respected
- Dominant language
- JavaScript
- Stars
- 658
- Forks
- 665
- Avg merge
- 19h 32m
- Merged PRs (30d)
- 5
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from exercism/javascript
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
exercism/javascript#2865 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
exercism/javascript#2847 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 42/100
exercism/javascript#2832 ·
-
Building a training set of tags for javascriptMay be free again @SleeplessByte claimed this 505 days ago, and no pull request is open. Open
exercism/javascript#2310 · 22 comments · 1 assignee ·
-
pinned :pushpin:
Difficulty 5/5 Over a week Newbie friendliness 5/100
exercism/javascript#2144 ·
All issues in exercism/javascript
Similar issues
-
Development server fails with webpack-dev-server 6.1.0Possibly taken @utsxvrai claimed this today. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
rabbitmq/rabbitmq-website#2733 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 80/100
kentcdodds/kcd-skills#32 ·
-
good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
tech-debt
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
enhancement frontend good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 2 days