Hacktoberfest 2026：维护者为十月标记出来的 issue，仍然开放、适合新手。 浏览 Hacktoberfest issue

Windowing System: Improvement Ideas

未关闭
  • 哪里不对？
#1,600 4 条评论 0 个 reaction 已指派 1 人 在 GitHub 查看

@SleeplessByte 已经在做这个了。

开始于 2022年2月7日。

评估

这个 Issue 还没有评估数据。

描述

discussion :speech_balloon:

After seeing a couple of solutions to "Windowing System" during mentoring, I think the exercise could need some changes to better achieve it's learning objectives.

  • For Position and Size, the constructor and the method have the same implementation. I saw a solution that used the method in the constructor which is not a very typical example.
  • There is no reason to use the methods to update values so students often just set the property values directly.
  • The calculation for the window resize and move is rather involved which does not add value for the actual learning objectives but it seems students spend quite some time finding creative solutions there, e.g.
    image

Some ideas how to improve the exercise:

  • Maybe we should expect some/all properties to be marked as private with the underscore to discourage the direct assignment. That might also make it easier to pick up unwanted code with the analyzer later. (Not sure how to best test in this case though. Either the test disrespects the underscore which is not a good example or the test needs to fall back on some user-implemented serialization function. But if that function is wrong all the tests will fail which is also annoying as everything else the user did could be correct.)
  • The methods on Position and Size could change the values by some amount instead of just setting a value. That would make them distinct from the constructor. (Probably only needed if we stick with "public properties".)
  • Simplify the window resize/move method e.g. by saying some lower bound is always respected
主要语言
JavaScript
星标
654
派生
660
平均合并
5 小时 31 分钟
30 天内合并 PR
4

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

exercism/javascript 的其他 Issue

查看 exercism/javascript 的全部 Issue

相似的 Issue

更多 JavaScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。