Windowing System: Improvement Ideas

Abierto
#1,600 4 comentarios 0 reacciones 1 asignado Ver en GitHub

@SleeplessByte ya está trabajando en esto.

Desde el 7/2/2022.

Evaluación

Este issue todavía no se ha evaluado.

Descripción

discussion :speech_balloon:

After seeing a couple of solutions to "Windowing System" during mentoring, I think the exercise could need some changes to better achieve it's learning objectives.

  • For Position and Size, the constructor and the method have the same implementation. I saw a solution that used the method in the constructor which is not a very typical example.
  • There is no reason to use the methods to update values so students often just set the property values directly.
  • The calculation for the window resize and move is rather involved which does not add value for the actual learning objectives but it seems students spend quite some time finding creative solutions there, e.g.
    image

Some ideas how to improve the exercise:

  • Maybe we should expect some/all properties to be marked as private with the underscore to discourage the direct assignment. That might also make it easier to pick up unwanted code with the analyzer later. (Not sure how to best test in this case though. Either the test disrespects the underscore which is not a good example or the test needs to fall back on some user-implemented serialization function. But if that function is wrong all the tests will fail which is also annoying as everything else the user did could be correct.)
  • The methods on Position and Size could change the values by some amount instead of just setting a value. That would make them distinct from the constructor. (Probably only needed if we stick with "public properties".)
  • Simplify the window resize/move method e.g. by saying some lower bound is always respected
Lenguaje dominante
JavaScript
Estrellas
652
Forks
658
Merge medio
19 h 37 min
PR fusionados (30 d)
6

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de exercism/javascript

Todos los issues de exercism/javascript

Issues similares

Más issues de JavaScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.