Handling unidentified/death keys in the keyboard history UI
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 48/100
- Tipo de issue
- Error
- Claridad
- Bastante claro
- Estado de actividad
- Estancado
- Stack tecnológico
- javascript
- Área
- frontend
Línea de trabajo
Start at app/static/js/app.js line 72, where the keyboard history relies on KeyboardEvent.key. Reproduce the alt+L case with the documented MacOS layout across Chrome, Safari, and Firefox, then verify that handling for Unidentified and Dead keys produces consistent, useful history in the UI without changing backend or HID behavior.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
I noticed one quirk in the UI, regarding the keypress history in the status bar. Note: this only affects the UI, not the backend or HID interface!
When the client machine is configured to use a keyboard layout that doesn’t provide a mapping for certain keys or key combinations, the keyboard history shows inconsistent results across browsers. From the view point of the target machine, however, things work as expected. So this issue is specific to using non-EN-US keyboard layouts.
I tested this on a MacOS machine with a customised keyboard layout, which doesn’t define a mapping for the alt+L key combination. So pressing alt+L on the client machine wouldn’t produce any character on the client machine itself. However, on the target machine, the alt+L combination may be well-defined, e.g. if the target machine uses a German keyboard layout where alt+L maps to the @ character. In this scenario, TinyPilot would forward the alt+L combination to the target machine, and produce the @ there.
In the TinyPilot’s web UI, however, I see these results in the status bar:
- Chrome displays:
alt+Unidentified(note: it’s notundefined!) - Safari displays:
alt+Dead - Firefox displays:
alt+l(as I would expect)
As stated in the documentation, the key property of the KeyboardEvent object may be Unidentified or Dead:
- If the KeyboardEvent represents the press of a dead key, the key value must be "
Dead".- If the key cannot be identified, the returned value is
Unidentified.
For the keyboard history, we rely on that key property, which is why we see this.
- Lenguaje dominante
- Python
- Estrellas
- 3.5k
- Forks
- 291
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de tiny-pilot/tinypilot
-
bug medium
Dificultad 2/5 1-3 horas Aptitud para principiantes 62/100
tiny-pilot/tinypilot#1419 ·
-
enhancement
Dificultad 5/5 Más de una semana Aptitud para principiantes 35/100
tiny-pilot/tinypilot#1929 · 3 comentarios ·
-
bug
Dificultad 3/5 1-2 días Aptitud para principiantes 35/100
tiny-pilot/tinypilot#1899 · 1 comentario ·
-
Dificultad 4/5 3-5 días Aptitud para principiantes 35/100
tiny-pilot/tinypilot#1896 ·
-
enhancement
Dificultad 5/5 Más de una semana Aptitud para principiantes 35/100
tiny-pilot/tinypilot#1882 ·
Todos los issues de tiny-pilot/tinypilot
Issues similares
-
agent-ready documentation needs-triage
Dificultad 1/5 1-3 horas Aptitud para principiantes 88/100
-
documentation
Dificultad 1/5 Menos de una hora Aptitud para principiantes 91/100
-
workflow-status page template still says reusable workflows are "triggered only by workflow_call:" Abierto
Dificultad 1/5 Menos de una hora Aptitud para principiantes 92/100
-
Add https://search.jeremyh.xyz/ Abiertoinstance instance add
Dificultad 1/5 Menos de una hora Aptitud para principiantes 72/100
searxng/searx-instances#939 · 1 comentario ·
-
area-deployment area-integrations triage:bot-seen
Dificultad 2/5 Medio día Aptitud para principiantes 86/100