The "You're in." confirmation doesn't say which email address it used

Cerrado Apto para principiantes
  • ¿Algo no está bien?
#715 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
85/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
next.js, react, typescript
Área
frontend

Línea de trabajo

Abre src/app/s/[slug]/commit-dialog.tsx y localiza la rama success; inserta la dirección enviada por correo en la primera línea cuando success.emailed sea true. Actualiza src/app/s/[slug]/signup-view.test.tsx para fijar ambos casos de redacción. Ejecuta pnpm lint && pnpm typecheck && pnpm knip && pnpm test; hecho cuando la confirmación de registro muestra la dirección y todas las comprobaciones pasan.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement pipeline:ready pipeline:ux

Needs your OK: this changes what people read after they sign up. Swap pipeline:proposed for pipeline:ready to have it built.

What happens

After someone signs up with an email, the "You're in." sheet (the success branch in src/app/s/[slug]/commit-dialog.tsx) says "We've saved your spot for . Bookmark this link to edit or cancel later:". It doesn't name the address it used, or say an email went out. The address first appears on the edit page ("You're editing this as …").

So a typo the suggestion list doesn't know goes unnoticed. suggestEmail (src/lib/email-suggest.ts) only checks a list of common providers: [email protected] gets "Did you mean …gmail.com?", but [email protected], or a typo in a school's own domain, gets nothing. That person gets no confirmation and no reminders, and nothing tells them why. Their browser also remembers the address, so the form fills in the same typo next time they sign up.

Fix, in outline

  • When success.emailed is true, name the address in the first line, before the link.
  • Leave the branch for an optional email left blank as it is.

Choices this makes

  • Wording. Default: "We've saved your spot for and emailed this link to . Bookmark it to edit or cancel later:". It says what happened and where, in one sentence.
  • No "wrong address?" action. Default: name the address only. The edit page can't change an email today, so a "change it" link would need that first. Someone who spots a typo can cancel and sign up again.

Watch for

  • src/app/s/[slug]/signup-view.test.tsx pins the "You're in." text.
  • Long addresses at 390px: the line must wrap, not scroll sideways.
  • CHANGELOG entry.

Done when

  • Signing up with an email shows that address in "You're in."; with an optional email left blank, the text is unchanged.
  • A test in signup-view.test.tsx pins both.
  • pnpm lint && pnpm typecheck && pnpm knip && pnpm test pass.

Found by the UX walkthrough, scenario P1, on opensignup-prod main at 1234209 (this repo at dc99921). Checked against commit-dialog.tsx and email-suggest.ts at dc99921.

Generated by Claude Code

Lenguaje dominante
TypeScript
Estrellas
19
Forks
4
Merge medio
19 h 15 min
PR fusionados (30 d)
205

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de richshaw/OpenSignup

Todos los issues de richshaw/OpenSignup

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.