MLX mode never reaches the mx.addmm dispatches because BlasOpt is excluded

Abierto
#2,525 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
1-2 días
Aptitud para principiantes
57/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
python

Línea de trabajo

Start by reading MLXLinker and the BlasOpt rewrite rules, then inspect the Gemv and Ger dispatches in link/mlx/dispatch/blas.py. Reproduce the two examples in the issue and inspect the MLX graph to confirm which rewrites run. Done when both expressions reach the intended mx.addmm dispatches and the outer product is handled in MLX mode.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

mlx performance

MLXLinker lists BlasOpt among its incompatible rewrites, so Gemv and Ger never appear in an MLX graph, and their mx.addmm dispatches in link/mlx/dispatch/blas.py are unreachable. A @ v + b runs as a Matmul plus a separate Add, and an outer product col @ row runs as a Matmul. local_dot_to_mul leaves core outer products alone so GER can handle them, but MLX mode never produces a GER. #2514 adds local_outer_dot_to_mul for Numba, which has no GER either, and tagging it mlx would cover the outer product. #2406 turns Gemv and Ger into plain Ops, but MLX still excludes BlasOpt there.

import re

import mlx.core as mx
import numpy as np
import pytensor
import pytensor.tensor as pt

A = pt.matrix("A", dtype="float32")
v = pt.vector("v", dtype="float32")
b = pt.vector("b", dtype="float32")
col = pt.matrix("col", shape=(None, 1), dtype="float32")
row = pt.matrix("row", shape=(1, None), dtype="float32")

rng = np.random.default_rng(0)
cases = {
    "A @ v + b": ([A, v, b], A @ v + b, [rng.normal(size=(5, 3)), rng.normal(size=3), rng.normal(size=5)]),
    "col @ row": ([col, row], col @ row, [rng.normal(size=(5, 1)), rng.normal(size=(1, 3))]),
}
for name, (inputs, output, values) in cases.items():
    fn = pytensor.function(inputs, output, mode="MLX")
    mx.export_to_dot("graph.dot", fn.vm.jit_fn(*[mx.array(value.astype("float32")) for value in values]))
    print(name, [type(node.op).__name__ for node in fn.maker.fgraph.toposort()], re.findall(r'label ="([^"]+)"', open("graph.dot").read()))
# A @ v + b ['DimShuffle', 'Dot', 'DimShuffle', 'Elemwise'] ['Transpose', 'Reshape', 'Matmul', 'Transpose', 'Reshape', 'Add']
# col @ row ['Dot'] ['Matmul']
Lenguaje dominante
Python
Estrellas
654
Forks
258
Merge medio
2 d 7 h
PR fusionados (30 d)
39

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de pymc-devs/pytensor

Todos los issues de pymc-devs/pytensor

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.