Deferred review findings from the CLI and download PR series
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 25/100
Línea de trabajo
Start by reading the cited CLI and download PRs (#167–#172) and structural issues #159, #161, #162, #163; the findings span viral stores, exit statuses, shared options, and data commands. Check which findings remain relevant after those issues, then address a narrowly scoped item and verify its behavior with the relevant CLI tests. Several findings are explicitly superseded or folded into other work, so the issue does not define one standalone completion target.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Code review of the CLI and download PR series (#167–#172) raised findings that were deliberately not fixed there. They are pre-existing gaps, pathological states, or cleanups that the structural issues (#159, #161, #162) will make easier or unnecessary. The blocking findings (regressions, data loss, false claims) were fixed in the PRs.
Viral stores (#170): mostly superseded once #159 moves collections onto VersionedDatasetRegistry
datacache.bundle_storeis imported although DataCache doesn't export it (the import is isolated in_bundle_store()with a clear error). The durable fix is to exportBundleStoreand a diagnose/repair hook from DataCache._store_problemchecks stores with rules that can differ from DataCache's ownBundleStorechecks, for example on stray.datacache-*files or a hard-linked or FIFO marker.- A future-dated stray entry under
bundles/sets the names of later bundles, and prune skips it. select_viral_referencescopies from the collection bundle outside the collection lock, so a concurrent explicitprune_viral_references(keep=1)can delete its source mid-copy.- The store marker is written without fsync, and
prune_viral_referencesreimplementsprune_bundles. prune_viral_referencesonly reaches the current bundle version and index schema.- A damaged selection is hashed twice before it is rebuilt.
- Replaced bundles are kept until an explicit prune (about 10 MB per refresh, by design).
Exit statuses (#172)
--referenceand--asseton search-reference commands are checked separately, so a valid but mismatched pair exits 1 instead of 2.- Restricted-terms checks are duplicated per command (
require_terms). ATermsNotAccepted(ValueError)raised bydownload_chainandfetch_dataand mapped byArgumentParser.failwould cover every caller. - Registry-file wrapping is duplicated in
catalog_clianddataset_cli, andASSET=PATHparsing incatalog_cli,genomes_clianddownload_cli(fold into #162 and #163). - Some option values are still validated only by library code and exit 1, as
docs/cli.mdsays.
Shared options (#171)
share_cache_rootmust be called by hand at the end of each group's parser setup; a subcommand added after the call loses the option.--registrystill works only before the subcommand.
Data commands (#168, #169)
- A repair leaves the damaged DataCache generation on disk until the cache is pruned (documented).
_showwrites its own truncation footer next toprint_table's.- The focused commands (
data catalog,data dataset, …) still need--forceto repair a damaged install (#162 turns them intodata fetchaliases).
- Lenguaje dominante
- Python
- Estrellas
- 1
- Forks
- 1
- Merge medio
- 10 h 11 min
- PR fusionados (30 d)
- 51
Preparar el entorno
Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de openvax/orfdata
-
Dificultad 4/5 3-5 días Aptitud para principiantes 45/100
Los mantenedores suelen responder en 1 día
-
Dificultad 4/5 3-5 días Aptitud para principiantes 42/100
Los mantenedores suelen responder en 1 día
-
Dificultad 4/5 3-5 días Aptitud para principiantes 48/100
openvax/orfdata#194 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
Dificultad 4/5 3-5 días Aptitud para principiantes 45/100
Los mantenedores suelen responder en 1 día
-
Dificultad 4/5 3-5 días Aptitud para principiantes 52/100
Los mantenedores suelen responder en 1 día
Todos los issues de openvax/orfdata
Issues similares
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 85/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 62/100
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
pearu/agent-sandbox#451 ·
Los mantenedores suelen responder en 1 día
-
run_gate loads a custom tasks file from outside the working directoryPosiblemente ocupada @Ru0k3 la tomó hoy. Abiertobug
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
MakazhanAlpamys/Soup#3189 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
review developer setup docAbierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
NYCPlanning/data-engineering#2996 ·
Los mantenedores suelen responder en 1 día