Five hand-written GTF readers disagree on attribute parsing and malformed rows

Abierto
#192 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
52/100
Tipo de issue
Refactorización
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
python
Área
data

Línea de trabajo

Start by reading orfdata/gtf.py and the five reader loops named in the issue, along with the existing GTF tests. Compare their row validation, attribute parsing, and header handling, then check how PyEnsembl provides gtfparse. Done means the five readers use one shared reader and tests cover malformed rows and quoted attribute values consistently.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Problem

ORFdata reads GTF files with five separate hand-written loops, each with its own attribute regex, row validation and header handling. They disagree on malformed input. A row without nine tab-separated fields is an error in three of them and is silently skipped in two. Attribute parsing uses three different patterns. A fix to any of them (for example the quote handling from #179) lands in one reader only. This is the GTF counterpart of #182 for FASTA. The stack's GTF reader, gtfparse, is already installed through PyEnsembl.

Evidence

Read at d8ab958.

Reader Rows read Attribute pattern Row with ≠ 9 fields
orfdata/gtf.py:145 read_exons (used by viral_installed.py:73) exon (\w+) "([^"]*)" (gtf.py:19) raises
orfdata/ensembl.py:69 _annotation transcript, CDS; reads #!genome-build-accession (\w+) "([^"]*)" raises
orfdata/sources/wang.py:115 _annotation all; reads #! headers (\w+) "([^\"]*)"; (needs the ;) raises
orfdata/sources/ncorf_mammals.py:61 _transcripts (also used by sources/riborf.py:135,201) exon (\S+) "([^"]*)" (ncorf_mammals.py:33) skipped (len(fields) < 9)
orfdata/sources/riborf_native.py:23 _annotations exon imports ncorf_mammals._ATTRIBUTE skipped (len(fields) != 9)

Each loop also opens the file itself: gzip.open in the three source modules, plain open in gtf.read_exons, and ensembl._source in ensembl.py.

Suggested fix

  • Add one public reader to orfdata/gtf.py. For example, read_gtf_rows(path, features=None) would yield (seqname, feature, start, end, strand, attributes) plus the #! header mapping, open plain or gzipped files, use one attribute parser (the inverse of gtf.attributes), and raise on malformed rows with path and line number. Alternatively, build it on gtfparse.read_gtf(..., features=...) and read the #! header lines separately.
  • Rewrite the five loops on top of it, keeping only their source-specific grouping and checks.
  • Add a test with one malformed row and one quoted attribute value that every caller must handle the same way.

https://claude.ai/code/session_01JHJhwj29oDqoeu7TYd34Pi

Lenguaje dominante
Python
Estrellas
1
Forks
1
Merge medio
10 h 11 min
PR fusionados (30 d)
51

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de openvax/orfdata

Todos los issues de openvax/orfdata

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.