Align orfdata with the openvax stack baseline (unused runtime biotite dependency, Biopython in tools, no develop.sh)
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 48/100
Línea de trabajo
Start with pyproject.toml, orfdata/fasta.py, and tools/verify_riborf_native.py; compare the package imports and dependency groups with the proposed biotite and Biopython changes. Check the alignment oracle in tests/test_dog_ncorf_search.py and the sibling libraries' develop.sh scripts for project conventions. Done means the dependency declarations, documentation, verification tool, and development setup agree with the chosen approach.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Problem
ORFdata meets the Python 3.11, pandas 3 and pyarrow baselines. Three deviations from the openvax stack remain:
- biotite is a runtime dependency that the package never uses, and FASTA I/O is hand-written.
pyproject.tomlrequiresbiotite>=1.6,<3, and the README says a normal install includes "Biotite alignment support". But no module underorfdata/imports biotite; onlyscripts/experimental/dog-ncorf-search/homology.pydoes, and that script is not part of the installed package. FASTA is read and written byorfdata/fasta.pyand by per-source loops. #182 already proposes moving those loops ontofasta.read_fasta. This item is about whatread_fastais built on. - Biopython is still imported, in a maintenance tool and a test. #131 moved the experimental dog search to biotite, and the 0.41.0 CHANGELOG keeps Biopython as a
devdependency "for independent comparisons". That rationale fits the test, which checks biotite's alignments against an independent implementation. It does not fittools/verify_riborf_native.py, which usesBio.SeqIOandBio.Seqto translate RibORF ORFs. ORFdata translates with its own genetic codes, not biotite, so biotite would be just as independent there. - No
develop.sh(consistency). 14 of the 16 openvax/pirl-unc libraries have one. ORFdata documentspython -m pip install -e '.[dev]'indocs/reference.md:367instead.
Evidence
Read at d8ab958.
biotite / FASTA
pyproject.toml:21:"biotite>=1.6,<3"in[project].dependencies.rg biotite orfdata/finds nothing. The only import isscripts/experimental/dog-ncorf-search/homology.py:3-4, and[tool.setuptools.packages.find]installs onlyorfdata*.orfdata/fasta.py:6-40: hand-writtenwrite_fastaandread_fasta. The reader raises on an empty header, a repeated identifier and sequence before the first header.- Per-source loops covered by #182 include:
ensembl.py:110_fasta,refseq.py:27_proteinsandproteome.py:906ProteinSet.from_fasta;sources/ncorf_mammals.py:36,sources/peptideatlas.py:76,sources/openprot.py:48,sources/pfizer.py:81andsources/riborf_native.py:61, all named_fasta;sources/riborf.py:66and:279.
biotite.sequence.io.fasta.FastaFile.read_iter(file)accepts a path or an open text handle (includinggzip.open(..., "rt")) and yields(header, sequence). It skips blank and;lines, does not check for repeated headers, and silently drops lines before the first header.FastaFile.write_iter(file, items, chars_per_line)writes records.
Biopython
pyproject.toml:31-32:dev = [..., "biopython>=1.88,<2"], with the comment "Biopython independently checks the Biotite migration's scores and tie order."tools/verify_riborf_native.py:3says "Uses Biopython translation". Lines 16–17 havefrom Bio import SeqIOandfrom Bio.Seq import Seq.tests/test_dog_ncorf_search.py:51-52,91importBio.Alignandsubstitution_matricesas the oracle for biotite's local alignment.CHANGELOG.md:237-239(0.41.0): "Biopython remains a development dependency for independent comparisons".
develop.sh
- Top level has
lint.sh,test.sh,deploy.shanddocs.sh, but nodevelop.sh.
Suggested fix
- biotite / FASTA: do one of these, so the requirement matches the code.
- Build
fasta.read_fastaandwrite_fastaonFastaFile.read_iterandwrite_iter. Keep the empty-header and repeated-identifier checks, and keep a first-line check for data before the first header, sinceread_iterdrops it. The loops that #182 consolidates then go through biotite too. - Or keep the hand-written reader, and move biotite from
[project].dependenciesto an extra used by the experimental script. Update the README sentence to match.
- Build
- Biopython:
- Port
tools/verify_riborf_native.pyto biotite:biotite.sequence.io.fastafor reading, andNucleotideSequence(...).translate(complete=True)with an explicit codon table. - That leaves the alignment oracle test as Biopython's only use. Either keep it as the one sanctioned exception and say so in the
devcomment, or replace it with fixed expected scores and tie orders and drop Biopython.
- Port
- develop.sh: add one running
pip install -e '.[dev]', as the siblings do.
- Lenguaje dominante
- Python
- Estrellas
- 1
- Forks
- 1
- Merge medio
- 10 h 11 min
- PR fusionados (30 d)
- 51
Preparar el entorno
Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de openvax/orfdata
-
Dificultad 4/5 3-5 días Aptitud para principiantes 45/100
Los mantenedores suelen responder en 1 día
-
Dificultad 4/5 3-5 días Aptitud para principiantes 42/100
Los mantenedores suelen responder en 1 día
-
Dificultad 4/5 3-5 días Aptitud para principiantes 45/100
Los mantenedores suelen responder en 1 día
-
Dificultad 4/5 3-5 días Aptitud para principiantes 52/100
Los mantenedores suelen responder en 1 día
-
Dificultad 4/5 3-5 días Aptitud para principiantes 52/100
Los mantenedores suelen responder en 1 día
Todos los issues de openvax/orfdata
Issues similares
-
[Bug]: DoubleMLData.from_arrays checks the treatment d with force_all_x_finite instead of force_all_d_finitePosiblemente ocupada @leninworld la tomó hoy. Abierto
Dificultad 1/5 Menos de una hora Aptitud para principiantes 88/100
DoubleML/doubleml-for-py#471 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
python-pillow/Pillow#10590 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 85/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 62/100
Los mantenedores suelen responder en 1 día
-
BUG: ZarrTrace fails in init_trace for models with datetime coordinates (object dtype coord array)Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 74/100
Los mantenedores suelen responder en 2 días