Docker: five images ignore docker stop and are killed at the timeout

Offen
#5,611 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
48/100
Issue-Typ
Bug
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
docker, typescript

Rechercherichtung

Read the five affected image definitions under src/filesystem, src/sequentialthinking, src/fetch, src/git, and src/time, then compare their stop behavior with everything and memory. Run the provided Docker reproduction and inspect scripts/image-smoke.mjs for the cleanStop checks. Done means all five containers stop promptly with their server's exit and the smoke entries assert clean stops; the signal handling approach still needs a decision.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

enhancement v2

Problem

Five of the seven Docker images do not exit on docker stop: filesystem, sequentialthinking, fetch, git and time. Docker sends the stop signal, the server ignores it, and Docker kills the container when its timeout runs out (exit 137). everything and memory exit on their own (exit 0 and 130), because their images declare STOPSIGNAL SIGINT and their servers handle it (#5485 for memory).

The cause is the same in each: the server runs as PID 1, which gets no default signal disposition, so a SIGTERM it installed no handler for is dropped.

Found while building the image smoke for #5598, which asserts a clean stop only for the two images that have one today.

Reproduce

Built from v2/main at 7f383a8e, Docker 29.8.1:

docker build -f src/filesystem/Dockerfile -t mcp/filesystem .
id=$(docker run -d -i mcp/filesystem /tmp)
docker stop "$id"                                   # waits out the timeout
docker inspect -f '{{.State.ExitCode}}' "$id"       # 137

The same for sequentialthinking, and for fetch, git and time built from their own directories. All five exit 137; everything exits 0 and memory 130.

Expected

docker stop ends each container promptly and with the server's own exit, as it does for everything and memory. None of the five keeps state that a kill corrupts today, so what a user sees is the stop taking the full timeout (10 seconds by default), per container, on every docker stop, docker compose down or orchestrator restart, most visibly when the server runs over Streamable HTTP.

To decide

  • Per image: a STOPSIGNAL the server already handles, a signal handler in the server, or an init process (docker run --init, tini) in the image.
  • When an image gains a clean stop, set cleanStop: true on its entry in scripts/image-smoke.mjs, so the image smoke asserts it (a script test already requires it of any image that declares a STOPSIGNAL).
Vorherrschende Sprache
TypeScript
Sterne
92k
Forks
12k
Ø Merge
3 Std. 46 Min.
Gemergte PRs (30 T.)
206

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus modelcontextprotocol/servers

Alle Issues in modelcontextprotocol/servers

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.