TokenEconomizer: repository-planted code runs in the plugin process; tmp writes follow symlinks

Abierto
#260 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@kevinveenbirkenbach ya está trabajando en esto.

Desde el 17/11/2026.

  • #261 de @kevinveenbirkenbach — abierto

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
20/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Estancado
Stack tecnológico
python

Línea de trabajo

Start with tokeneconomizer/plugin/context.py and tokeneconomizer/plugin/denylist.py, then review linked pull request #261. The report describes module shadowing when spawning the CLI and symlink following for temporary writes; check the existing tests for those paths. Done means both reported attack paths are addressed and covered by tests.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Product: microsoft/TokenEconomizer, Claude Code / Codex plugin.
Affected: commit b57d03f81585a18b936a0eaecbd1eb51cdcecf71 (main on 2026-11-17).
Channel: private report per SECURITY.md (aka.ms/SECURITY.md); not filed as a public issue.

Context

Coding agents typically run their tool calls inside a sandbox that may write
the repository but not the user's configuration. Plugin hooks run outside that
sandbox. Both issues let content an agent (or a cloned repository) places in
the repository act with the hook's unsandboxed privileges.

Issue 1: module shadowing in the spawned CLI (code execution)

tokeneconomizer/plugin/context.py (around lines 84-93) starts
[sys.executable, "-m", "tokeneconomizer.plugin.cli", ...] with
cwd=self.repo.root and no -P/-I. With -m, Python puts the current
directory first on sys.path, ahead of PYTHONPATH. A file such as json.py,
or a tokeneconomizer/ package, in the repository root is imported instead of
the real module and runs in the plugin's process. This path is reached on
session-end and session-start folds regardless of configuration, and for the
loop-guard judge and pending applies.

Reproduction (no plugin code needed): in an empty directory create json.py
containing print("planted"), then run python3 -m json.tool --help there:
planted is printed. With PYTHONSAFEPATH=1 it is not.

Issue 2: symlink write-through of the temporary file

write_json and _write_text in tokeneconomizer/plugin/denylist.py
(around lines 124-138) open path + ".te.tmp" with open(tmp, "w").
_guard_target checks only the final path. A symlink planted at
.claude/settings.local.json.te.tmp makes the write land on the link target,
for example the user-wide ~/.claude/settings.json; the written JSON derives
from the repository's own settings.local.json, so it can carry hooks.
With the default toolprune=auto, the write happens without user action.

Reproduction: plant the symlink .claude/settings.local.json.te.tmp -> /some/victim.json, call denylist.write_json(".claude/settings.local.json", {...}): the victim is overwritten, the target is not created.

Suggested fix (tested locally)

--- a/tokeneconomizer/plugin/context.py
+++ b/tokeneconomizer/plugin/context.py
         env["PYTHONUTF8"] = "1"
+        env["PYTHONSAFEPATH"] = "1"
         cmd = [sys.executable, "-m", "tokeneconomizer.plugin.cli", *argv,
--- a/tokeneconomizer/plugin/denylist.py
+++ b/tokeneconomizer/plugin/denylist.py
+def _open_tmp(tmp):
+    if os.path.lexists(tmp):
+        os.unlink(tmp)
+    flags = os.O_WRONLY | os.O_CREAT | os.O_EXCL | getattr(os, "O_NOFOLLOW", 0)
+    return os.fdopen(os.open(tmp, flags, 0o666), "w", encoding="utf-8")

write_json and _write_text then open the temporary file through
_open_tmp. PYTHONSAFEPATH needs Python 3.11+; for 3.10 a cwd outside the
repository (the --cwd argument already carries the root) closes issue 1 too.

Two further observations, lower severity: on Codex the judge runs
codex exec -s read-only, which can still read files the user's agent sandbox
denies; plugin state is keyed by the origin remote URL, so a repository that
copies another's URL shares its learned state.


PS: I would had liked to report this vulnerability over your website, but it was impossible to register.

Lenguaje dominante
Python
Estrellas
7.4k
Forks
500
Merge medio
1 d 9 h
PR fusionados (30 d)
124

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de microsoft/TokenEconomizer

Todos los issues de microsoft/TokenEconomizer

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.