TokenEconomizer: repository-planted code runs in the plugin process; tmp writes follow symlinks
维护者通常 1 天内回复
评估
调研方向
Start with tokeneconomizer/plugin/context.py and tokeneconomizer/plugin/denylist.py, then review linked pull request #261. The report describes module shadowing when spawning the CLI and symlink following for temporary writes; check the existing tests for those paths. Done means both reported attack paths are addressed and covered by tests.
由索引模型根据 Issue 内容生成。
描述
Product: microsoft/TokenEconomizer, Claude Code / Codex plugin.
Affected: commit b57d03f81585a18b936a0eaecbd1eb51cdcecf71 (main on 2026-11-17).
Channel: private report per SECURITY.md (aka.ms/SECURITY.md); not filed as a public issue.
Context
Coding agents typically run their tool calls inside a sandbox that may write
the repository but not the user's configuration. Plugin hooks run outside that
sandbox. Both issues let content an agent (or a cloned repository) places in
the repository act with the hook's unsandboxed privileges.
Issue 1: module shadowing in the spawned CLI (code execution)
tokeneconomizer/plugin/context.py (around lines 84-93) starts
[sys.executable, "-m", "tokeneconomizer.plugin.cli", ...] with
cwd=self.repo.root and no -P/-I. With -m, Python puts the current
directory first on sys.path, ahead of PYTHONPATH. A file such as json.py,
or a tokeneconomizer/ package, in the repository root is imported instead of
the real module and runs in the plugin's process. This path is reached on
session-end and session-start folds regardless of configuration, and for the
loop-guard judge and pending applies.
Reproduction (no plugin code needed): in an empty directory create json.py
containing print("planted"), then run python3 -m json.tool --help there:
planted is printed. With PYTHONSAFEPATH=1 it is not.
Issue 2: symlink write-through of the temporary file
write_json and _write_text in tokeneconomizer/plugin/denylist.py
(around lines 124-138) open path + ".te.tmp" with open(tmp, "w").
_guard_target checks only the final path. A symlink planted at
.claude/settings.local.json.te.tmp makes the write land on the link target,
for example the user-wide ~/.claude/settings.json; the written JSON derives
from the repository's own settings.local.json, so it can carry hooks.
With the default toolprune=auto, the write happens without user action.
Reproduction: plant the symlink .claude/settings.local.json.te.tmp -> /some/victim.json, call denylist.write_json(".claude/settings.local.json", {...}): the victim is overwritten, the target is not created.
Suggested fix (tested locally)
--- a/tokeneconomizer/plugin/context.py
+++ b/tokeneconomizer/plugin/context.py
env["PYTHONUTF8"] = "1"
+ env["PYTHONSAFEPATH"] = "1"
cmd = [sys.executable, "-m", "tokeneconomizer.plugin.cli", *argv,
--- a/tokeneconomizer/plugin/denylist.py
+++ b/tokeneconomizer/plugin/denylist.py
+def _open_tmp(tmp):
+ if os.path.lexists(tmp):
+ os.unlink(tmp)
+ flags = os.O_WRONLY | os.O_CREAT | os.O_EXCL | getattr(os, "O_NOFOLLOW", 0)
+ return os.fdopen(os.open(tmp, flags, 0o666), "w", encoding="utf-8")
write_json and _write_text then open the temporary file through
_open_tmp. PYTHONSAFEPATH needs Python 3.11+; for 3.10 a cwd outside the
repository (the --cwd argument already carries the root) closes issue 1 too.
Two further observations, lower severity: on Codex the judge runs
codex exec -s read-only, which can still read files the user's agent sandbox
denies; plugin state is keyed by the origin remote URL, so a repository that
copies another's URL shares its learned state.
PS: I would had liked to report this vulnerability over your website, but it was impossible to register.
- 主要语言
- Python
- 星标
- 7.4k
- 派生
- 500
- 平均合并
- 1 天 9 小时
- 30 天内合并 PR
- 124
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
microsoft/TokenEconomizer 的其他 Issue
-
Pi: paused model calls are reported as "not signed in" when the model's provider comes from an extension可能已有人在做 @balcsida 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 73/100
microsoft/TokenEconomizer#288 ·
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 45/100
microsoft/TokenEconomizer#264 ·
维护者通常 1 天内回复
-
难度 5/5 一周以上 新手友好度 15/100
microsoft/TokenEconomizer#232 ·
维护者通常 1 天内回复
-
难度 5/5 一周以上 新手友好度 25/100
microsoft/TokenEconomizer#205 ·
维护者通常 1 天内回复
-
难度 5/5 一周以上 新手友好度 35/100
microsoft/TokenEconomizer#193 ·
维护者通常 1 天内回复
查看 microsoft/TokenEconomizer 的全部 Issue
相似的 Issue
-
[Bug]: reme CLI crashes when the running server used a relative config path可能已有人在做 @nurlanmnn 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 88/100
agentscope-ai/ReMe#770 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 67/100
sickn33/agentic-awesome-skills#2437 ·
维护者通常 1 天内回复
-
site-bug triage
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
ethereum/consensus-specs#5846 ·
维护者通常 1 天内回复
-
documentation
难度 1/5 1 小时以内 新手友好度 74/100
BrainLesion/BraTS#200 ·