TokenEconomizer: repository-planted code runs in the plugin process; tmp writes follow symlinks

未关闭
#260 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

@kevinveenbirkenbach 已经在做这个了。

开始于 2026年11月17日。

  • #261 来自 @kevinveenbirkenbach —— 未关闭

评估

难度
4/5
预计耗时
3-5 天
新手友好度
20/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
停滞
技术栈
python
领域
devtools, security

调研方向

Start with tokeneconomizer/plugin/context.py and tokeneconomizer/plugin/denylist.py, then review linked pull request #261. The report describes module shadowing when spawning the CLI and symlink following for temporary writes; check the existing tests for those paths. Done means both reported attack paths are addressed and covered by tests.

由索引模型根据 Issue 内容生成。

描述

Product: microsoft/TokenEconomizer, Claude Code / Codex plugin.
Affected: commit b57d03f81585a18b936a0eaecbd1eb51cdcecf71 (main on 2026-11-17).
Channel: private report per SECURITY.md (aka.ms/SECURITY.md); not filed as a public issue.

Context

Coding agents typically run their tool calls inside a sandbox that may write
the repository but not the user's configuration. Plugin hooks run outside that
sandbox. Both issues let content an agent (or a cloned repository) places in
the repository act with the hook's unsandboxed privileges.

Issue 1: module shadowing in the spawned CLI (code execution)

tokeneconomizer/plugin/context.py (around lines 84-93) starts
[sys.executable, "-m", "tokeneconomizer.plugin.cli", ...] with
cwd=self.repo.root and no -P/-I. With -m, Python puts the current
directory first on sys.path, ahead of PYTHONPATH. A file such as json.py,
or a tokeneconomizer/ package, in the repository root is imported instead of
the real module and runs in the plugin's process. This path is reached on
session-end and session-start folds regardless of configuration, and for the
loop-guard judge and pending applies.

Reproduction (no plugin code needed): in an empty directory create json.py
containing print("planted"), then run python3 -m json.tool --help there:
planted is printed. With PYTHONSAFEPATH=1 it is not.

Issue 2: symlink write-through of the temporary file

write_json and _write_text in tokeneconomizer/plugin/denylist.py
(around lines 124-138) open path + ".te.tmp" with open(tmp, "w").
_guard_target checks only the final path. A symlink planted at
.claude/settings.local.json.te.tmp makes the write land on the link target,
for example the user-wide ~/.claude/settings.json; the written JSON derives
from the repository's own settings.local.json, so it can carry hooks.
With the default toolprune=auto, the write happens without user action.

Reproduction: plant the symlink .claude/settings.local.json.te.tmp -> /some/victim.json, call denylist.write_json(".claude/settings.local.json", {...}): the victim is overwritten, the target is not created.

Suggested fix (tested locally)

--- a/tokeneconomizer/plugin/context.py
+++ b/tokeneconomizer/plugin/context.py
         env["PYTHONUTF8"] = "1"
+        env["PYTHONSAFEPATH"] = "1"
         cmd = [sys.executable, "-m", "tokeneconomizer.plugin.cli", *argv,
--- a/tokeneconomizer/plugin/denylist.py
+++ b/tokeneconomizer/plugin/denylist.py
+def _open_tmp(tmp):
+    if os.path.lexists(tmp):
+        os.unlink(tmp)
+    flags = os.O_WRONLY | os.O_CREAT | os.O_EXCL | getattr(os, "O_NOFOLLOW", 0)
+    return os.fdopen(os.open(tmp, flags, 0o666), "w", encoding="utf-8")

write_json and _write_text then open the temporary file through
_open_tmp. PYTHONSAFEPATH needs Python 3.11+; for 3.10 a cwd outside the
repository (the --cwd argument already carries the root) closes issue 1 too.

Two further observations, lower severity: on Codex the judge runs
codex exec -s read-only, which can still read files the user's agent sandbox
denies; plugin state is keyed by the origin remote URL, so a repository that
copies another's URL shares its learned state.


PS: I would had liked to report this vulnerability over your website, but it was impossible to register.

主要语言
Python
星标
7.4k
派生
500
平均合并
1 天 9 小时
30 天内合并 PR
124

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

microsoft/TokenEconomizer 的其他 Issue

查看 microsoft/TokenEconomizer 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。