Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

No limit on how late a queued FLOOD packet can be sent, so a delayed packet can re-flood the mesh

Abierto
  • ¿Algo no está bien?
#3,562 1 comentario 1 reacción 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
45/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
c
Área
networking

Línea de trabajo

Start with Dispatcher::checkSend(), PacketQueue::get(), and Mesh::routeRecvPacket() to trace how queued FLOOD packets are prioritized and sent. Then inspect PacketManager and StaticPoolPacketManager for the removal path, and the native gtests described in the issue for coverage. Done means overdue FLOOD packets are dropped at the configured limit, DIRECT packets remain unaffected, and the starvation scenario is covered.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Related to #2133 (auto-closed as stale), where several meshes reported old public-channel messages reappearing with the same packet hash and original timestamp.

Behaviour

Two behaviours combine:

  1. The duplicate table only remembers recent packets. SimpleMeshTables holds the last 160 packet hashes (MAX_PACKET_HASHES), with no time component. On a busy mesh it can refill within minutes.
  2. The outbound queue has no age limit. PacketQueue::get() always sends the highest-priority due packet first. Flood re-sends use priority = hop count (Mesh::routeRecvPacket), and direct/routed traffic is priority 0. Under sustained higher-priority traffic, plus airtime-budget and CAD waits, a long-path flood can be held well past its scheduled time. Nothing caps how late it can go out.

If a delayed flood goes out after neighbours have forgotten its hash, they treat it as new and flood it across the mesh again with a normal-looking path. loop.detect doesn't catch this.

How this relates to #2133

Realistically, this produces delays of seconds to minutes, not hours, because the queue has only 32 slots. So it probably doesn't explain the 2–3 hour reports in #2133 by itself. Those may involve an external replay, e.g. a bridge or IP backhaul that buffers raw packets. Still, nothing in the queue limits how late a flood can be sent, and that seems worth closing off.

Proposed change

Before each send attempt, Dispatcher::checkSend() drops any queued FLOOD packet whose scheduled send time is more than MAX_FLOOD_TX_OVERDUE_MILLIS (default 60 s) in the past.

  • Can be set at build time (-D MAX_FLOOD_TX_OVERDUE_MILLIS=...) or per node by overriding getMaxFloodTxOverdue(). 0 disables it.
  • DIRECT packets are not affected.
  • New PacketManager::removeOverdueFlood(), which does nothing by default so other PacketManager implementations still compile. StaticPoolPacketManager implements it.
  • Native gtest coverage for the queue function and for Dispatcher, using a fake radio and clock, including a starvation scenario. Dispatcher.cpp is now part of the native test build.

Branch: fix/expire-stale-outbound-floods. I'm happy to adjust the default limit or make it a CLI pref (e.g. set flood.max.delay) if preferred

Lenguaje dominante
C
Estrellas
3.9k
Forks
1.5k
Merge medio
1 d 3 h
PR fusionados (30 d)
24

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de meshcore-dev/MeshCore

Todos los issues de meshcore-dev/MeshCore

Issues similares

Más issues de C

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.