Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

No limit on how late a queued FLOOD packet can be sent, so a delayed packet can re-flood the mesh

Aperta
  • Qualcosa non va?
#3,562 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
45/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
c
Ambito
networking

Direzione di ricerca

Start with Dispatcher::checkSend(), PacketQueue::get(), and Mesh::routeRecvPacket() to trace how queued FLOOD packets are prioritized and sent. Then inspect PacketManager and StaticPoolPacketManager for the removal path, and the native gtests described in the issue for coverage. Done means overdue FLOOD packets are dropped at the configured limit, DIRECT packets remain unaffected, and the starvation scenario is covered.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Related to #2133 (auto-closed as stale), where several meshes reported old public-channel messages reappearing with the same packet hash and original timestamp.

Behaviour

Two behaviours combine:

  1. The duplicate table only remembers recent packets. SimpleMeshTables holds the last 160 packet hashes (MAX_PACKET_HASHES), with no time component. On a busy mesh it can refill within minutes.
  2. The outbound queue has no age limit. PacketQueue::get() always sends the highest-priority due packet first. Flood re-sends use priority = hop count (Mesh::routeRecvPacket), and direct/routed traffic is priority 0. Under sustained higher-priority traffic, plus airtime-budget and CAD waits, a long-path flood can be held well past its scheduled time. Nothing caps how late it can go out.

If a delayed flood goes out after neighbours have forgotten its hash, they treat it as new and flood it across the mesh again with a normal-looking path. loop.detect doesn't catch this.

How this relates to #2133

Realistically, this produces delays of seconds to minutes, not hours, because the queue has only 32 slots. So it probably doesn't explain the 2–3 hour reports in #2133 by itself. Those may involve an external replay, e.g. a bridge or IP backhaul that buffers raw packets. Still, nothing in the queue limits how late a flood can be sent, and that seems worth closing off.

Proposed change

Before each send attempt, Dispatcher::checkSend() drops any queued FLOOD packet whose scheduled send time is more than MAX_FLOOD_TX_OVERDUE_MILLIS (default 60 s) in the past.

  • Can be set at build time (-D MAX_FLOOD_TX_OVERDUE_MILLIS=...) or per node by overriding getMaxFloodTxOverdue(). 0 disables it.
  • DIRECT packets are not affected.
  • New PacketManager::removeOverdueFlood(), which does nothing by default so other PacketManager implementations still compile. StaticPoolPacketManager implements it.
  • Native gtest coverage for the queue function and for Dispatcher, using a fake radio and clock, including a starvation scenario. Dispatcher.cpp is now part of the native test build.

Branch: fix/expire-stale-outbound-floods. I'm happy to adjust the default limit or make it a CLI pref (e.g. set flood.max.delay) if preferred

Lingua principale
C
Stelle
3.9k
Fork
1.5k
Merge medio
1g 3h
PR unite (30g)
24

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di meshcore-dev/MeshCore

Tutte le issue di meshcore-dev/MeshCore

Issue simili

Altre issue su C

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.