Make the Lance storage engine an optional feature (DataFusion-only build)

Abierto
#171 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
25/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
rust

Línea de trabajo

The work spans feature declarations and conditional code across 9 files; the issue does not name those files. Start by reading how delta and unity-catalog features gate dependencies and code, then inspect the Lance paths listed in the proposal. Done means the DataFusion-only build excludes Lance dependencies while default builds retain existing behavior; the issue reports test and clippy results for both configurations.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Would you accept a PR that makes the Lance storage engine an optional feature?

We use lance-graph's Cypher parser and DataFusion planner over our own tables, registered in a SessionContext and run with execute_with_context. That path doesn't touch Lance. Even so, lance, lance-linalg and lance-namespace are required dependencies. They bring a large dependency tree (OpenSSL, ring, a protoc build step) that we can't ship in our environment.

Proposal. Add a default-on lance feature to lance-graph and lance-graph-catalog, in the same way delta and unity-catalog are gated today. It would gate:

  • the lance, lance-linalg and lance-namespace dependencies;
  • DirNamespace and the execute_with_namespace* paths;
  • Lance vector search (VectorSearch, execute_with_vector_rerank).

Nothing changes for existing users. With default-features = false, the Cypher engine builds as a DataFusion-only library.

There is also one small fix that applies either way. sql_query.rs uses DataFusion's sql feature, but it is enabled only transitively through lance, so it should be declared directly.

Status. I have this ready on top of main (e260cf6). It is about 40 lines across 9 files:

  • cargo test -p lance-graph --no-default-features: 550 passed, with no lance*, openssl-sys or ring in cargo tree -e normal;
  • the default features: 598 passed;
  • clippy is clean both ways.

If this direction works for you, I'll open the PR. If you'd rather keep Lance required (for example, because of where the CSR / native traversal work is heading), that's useful to know too.

Drafted with an AI coding assistant; reviewed and tested by the author.

Lenguaje dominante
Rust
Estrellas
189
Forks
40
Merge medio
16 min
PR fusionados (30 d)
1

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de lance-format/lance-graph

Todos los issues de lance-format/lance-graph

Issues similares

Más issues de Rust

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.