Make the Lance storage engine an optional feature (DataFusion-only build)

Aperta
#171 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
25/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
rust
Ambito
backend, databases

Direzione di ricerca

The work spans feature declarations and conditional code across 9 files; the issue does not name those files. Start by reading how delta and unity-catalog features gate dependencies and code, then inspect the Lance paths listed in the proposal. Done means the DataFusion-only build excludes Lance dependencies while default builds retain existing behavior; the issue reports test and clippy results for both configurations.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Would you accept a PR that makes the Lance storage engine an optional feature?

We use lance-graph's Cypher parser and DataFusion planner over our own tables, registered in a SessionContext and run with execute_with_context. That path doesn't touch Lance. Even so, lance, lance-linalg and lance-namespace are required dependencies. They bring a large dependency tree (OpenSSL, ring, a protoc build step) that we can't ship in our environment.

Proposal. Add a default-on lance feature to lance-graph and lance-graph-catalog, in the same way delta and unity-catalog are gated today. It would gate:

  • the lance, lance-linalg and lance-namespace dependencies;
  • DirNamespace and the execute_with_namespace* paths;
  • Lance vector search (VectorSearch, execute_with_vector_rerank).

Nothing changes for existing users. With default-features = false, the Cypher engine builds as a DataFusion-only library.

There is also one small fix that applies either way. sql_query.rs uses DataFusion's sql feature, but it is enabled only transitively through lance, so it should be declared directly.

Status. I have this ready on top of main (e260cf6). It is about 40 lines across 9 files:

  • cargo test -p lance-graph --no-default-features: 550 passed, with no lance*, openssl-sys or ring in cargo tree -e normal;
  • the default features: 598 passed;
  • clippy is clean both ways.

If this direction works for you, I'll open the PR. If you'd rather keep Lance required (for example, because of where the CSR / native traversal work is heading), that's useful to know too.

Drafted with an AI coding assistant; reviewed and tested by the author.

Lingua principale
Rust
Stelle
189
Fork
40
Merge medio
16m
PR unite (30g)
1

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di lance-format/lance-graph

Tutte le issue di lance-format/lance-graph

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.