Undirected relationship patterns match outgoing edges only

Abierto
#170 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
1-2 días
Aptitud para principiantes
55/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
rust
Área
databases

Línea de trabajo

Start in datafusion_planner/join_ops.rs and trace the RelationshipDirection::Undirected cases named in the issue. Read test_undirected_join_qualified_keys and compare its key-name assertions with the Alice → Bob reproduction. Done when the query returns Alice from Bob’s undirected match and tests cover both edge directions and self-loops.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

An undirected relationship pattern, (a)-[:R]-(b), is planned as outgoing only, so it misses every edge that points at a.

Repro (on main, e260cf6): one edge, Alice → Bob.

// Person(id, name) = [(1, "Alice"), (2, "Bob")]; KNOWS(src, dst) = [(1, 2)]
let config = GraphConfig::builder()
    .with_node_label("Person", "id")
    .with_relationship("KNOWS", "src", "dst")
    .build()?;
// MATCH (a:Person)-[:KNOWS]-(b:Person) WHERE a.name = 'Alice' RETURN b.name  -> ["Bob"]  (ok)
// MATCH (a:Person)-[:KNOWS]-(b:Person) WHERE a.name = 'Bob'   RETURN b.name  -> []       (expected ["Alice"])

Cause. In datafusion_planner/join_ops.rs, RelationshipDirection::Undirected picks the same keys as Outgoing in each match (lines 101, 146, 222, 249, 261): source joins source_id_field, target joins target_id_field. test_undirected_join_qualified_keys checks the qualified key names, not that both directions are matched.

A possible fix. Plan an undirected expand as the union of the outgoing and the incoming expand, each with its own keys, deduplicating only a self-loop that both would return. A single join on (a = src AND b = dst) OR (a = dst AND b = src) also works, but DataFusion then cannot use a hash join on it. Variable-length paths built from the unrolled expands would pick this up as well. Happy to open a PR along those lines if that approach suits you.

Lenguaje dominante
Rust
Estrellas
189
Forks
40
Merge medio
16 min
PR fusionados (30 d)
1

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de lance-format/lance-graph

Todos los issues de lance-format/lance-graph

Issues similares

Más issues de Rust

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.