alternative server_method api
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 25/100
Línea de trabajo
Comienza rastreando el comportamiento existente de server_methods y cómo se cargan las declaraciones de app/hyperstack/models y app/models en el cliente y en el servidor. Define el alcance de remote_access_to, los bloques de seguridad compartidos, las definiciones exclusivas del servidor y no_cache; después, verifica que el comportamiento existente de los métodos del servidor se mantenga intacto.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
given you have an existing model, which needs some of the methods to be defined as server_methods, it would be nice to say something like:
remote_access_to(:foo, :bar) { acting_user.admin? }
where foo and bar are existing instance methods.
or
remote_access_to(:foo, bar: 12) ...
which will give a default value of 12 to bar.
This is nice not only because it allows for existing methods to be declared as server methods without modification, but it also allows for a common security block to be provided, instead of repeating it. It also is a nicer separation of concerns.
Basic implementation is straight forward: On the client methods :foo and :bar are defined like any other server method, and will call the method with the security name prefix. On the server, the secured method calls the block, and if successfully returns true, continues on and calls the method.
There are complexities:
-
if the remote_access_to declaration is placed BEFORE the definition of foo and bar, you have to make sure that those definitions are server only. It might be possible by redefining define_method, to check for this case...
-
If foo and bar are server side only, then it would be nice if they could be declared in a file that is in app/models. This can be done by putting the server and client defs in
app/hyperstack/models, and then putting server only defs inapp/modelsand adding arequire Rails.root.join('app', 'models', 'sample.rb') unless RUBY_ENGINE == 'opal'at the start of the file, and maybe with some hacking we could make a method calledrequire_server_definitionsthat would automatically figure out the file being loaded, and then load the same file from app/models.
And a nice feature:
server_methods by default assume that they are returning a value, and thus will cache the value on the client once its retrieved. You can force a re-retrieval of the value by adding a ! to the method name. But in many cases you just want the method to be run on the server every time its called, anyway. So how about a no_cache parameter added to the server method args.
- Lenguaje dominante
- JavaScript
- Estrellas
- 538
- Forks
- 41
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de hyperstack-org/hyperstack
-
expose_as_operations method Abiertoenhancement needs doc
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
hyperstack-org/hyperstack#359 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
hyperstack-org/hyperstack#267 ·
-
Dificultad 5/5 Más de una semana Aptitud para principiantes 25/100
hyperstack-org/hyperstack#457 ·
-
Dificultad 3/5 1-2 días Aptitud para principiantes 35/100
hyperstack-org/hyperstack#456 ·
-
Dificultad 5/5 Más de una semana Aptitud para principiantes 15/100
hyperstack-org/hyperstack#455 · 2 comentarios ·
Todos los issues de hyperstack-org/hyperstack
Issues similares
-
ai-observability bug team/ai-observability
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
AllTheMods/ATM-10-L#19 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
SignalK/n2k-signalk#345 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
-
Dificultad 1/5 1-3 horas Aptitud para principiantes 88/100
JuliaPluto/PlutoPlotly.jl#72 ·