FileArtifactService changes CRLF and CR line endings in text artifacts

Abierto Apto para principiantes
  • ¿Algo no está bien?
#7,914 1 comentario 0 reacciones 1 asignado Ver en GitHub

Los mantenedores suelen responder en 4 días

@sanketpatil06 ya está trabajando en esto.

Desde el 2/11/2026.

  • #7915 de @emme1t — abierto
  • #7917 de @TINGyu123644 — cerrado sin fusionar

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
85/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
python
Área
backend

Línea de trabajo

Empieza con google/adk/artifacts/file_artifact_service.py y sigue cómo se guarda y carga el texto; el script de reproducción del issue muestra los casos de saltos de línea que hay que comprobar. Ejecuta ese script y verifica después que los artefactos respaldados por archivos devuelvan el texto guardado sin cambios, incluidos los finales de línea CRLF y CR aislado.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

request clarification services

🔴 Required Information

Describe the Bug:

FileArtifactService changes the line endings of text artifacts. A text artifact containing \r\n or a lone \r loads back with \n in their place. The payload is read with Path.read_text, whose universal newline mode rewrites both. It is written with Path.write_text, which translates \n to os.linesep, so on Windows every \n is stored as \r\n.

InMemoryArtifactService and GcsArtifactService return the saved text unchanged, so the same artifact differs only on the file backend. That backend is what adk web and adk run use by default (use_local_storage=True, via create_local_artifact_service). CSV files (RFC 4180 uses CRLF), patches, and Windows-authored text a tool saves therefore load back different from what was saved.

Steps to Reproduce:

  1. pip install google-adk (reproduced on main at 8cd3b12c8)
  2. Run:
import asyncio, tempfile
from google.genai import types
from google.adk.artifacts.file_artifact_service import FileArtifactService
from google.adk.artifacts.in_memory_artifact_service import InMemoryArtifactService

async def main():
  text = "id,name\r\n1,a\r\n2,b\rc\n"
  for svc in (FileArtifactService(root_dir=tempfile.mkdtemp()), InMemoryArtifactService()):
    await svc.save_artifact(app_name="a", user_id="u", session_id="s",
                            filename="t.csv", artifact=types.Part(text=text))
    got = await svc.load_artifact(app_name="a", user_id="u", session_id="s",
                                  filename="t.csv")
    print(type(svc).__name__, repr(got.text), got.text == text)

asyncio.run(main())

Expected Behavior:

Both services return the saved text unchanged.

Observed Behavior:

FileArtifactService 'id,name\n1,a\n2,b\nc\n' False
InMemoryArtifactService 'id,name\r\n1,a\r\n2,b\rc\n' True

Environment Details:

  • ADK Library Version (pip show google-adk): 2.13.0 (main at 8cd3b12c8)
  • Desktop OS: macOS (the read-side rewrite is platform independent; the write-side translation affects Windows)
  • Python Version (python -V): 3.11

Model Information:

  • Are you using LiteLLM: No
  • Which model is being used: N/A (artifact service only)

🟡 Optional Information

Regression:

Not that I know of. The file backend has read and written text payloads with read_text / write_text.

Additional Context:

I would like to contribute a focused fix for this. Would writing artifact.text.encode("utf-8") with write_bytes and decoding read_bytes() on load be an acceptable approach? This keeps the stored payload exactly equal to the saved text. The error handling stays the same (OSError / UnicodeDecodeError are still caught and logged). Metadata JSON reads and writes are unaffected, since JSON escapes CR/LF inside strings.

How often has this issue occurred?:

  • Always (100%)
Lenguaje dominante
Python
Estrellas
22.1k
Forks
4.3k
Merge medio
1 d 10 h
PR fusionados (30 d)
5

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de google/adk-python

Todos los issues de google/adk-python

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.