Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

pull_request_read silently ignores pagination parameters that don't apply to the selected method

Abierto
#3,316 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
76/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
github, go
Área
api, backend

Línea de trabajo

Start in pullrequests.go at the pull_request_read dispatch and review the existing method validation before dispatching. Use utils.NewToolResultError for unsupported pagination parameters, naming the selected method and parameter; done means mismatched page/perPage or after inputs return clear validation errors instead of being ignored.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Describe the bug

pull_request_read exposes two pagination mechanisms in one schema:

  • page / perPage — used by get_files, get_commits, get_reviews, get_comments, get_check_runs
  • after (cursor) — used only by get_review_comments

When a caller passes a parameter the selected method doesn't use, the
server silently drops it and returns results as if it were never sent.
There is no error, warning, or hint in the response.

The schema description for after does say "used only by the
get_review_comments method", and the code comment confirms other methods
"ignore after" — but for an LLM caller a description is guidance, not
enforcement. The model sees a pagination cursor in the schema, receives a
page of files, and passes after to fetch the next page. It gets the first
page again and has no signal that anything was ignored.

The symmetric case also applies: passing page to get_review_comments
is silently ignored.

Steps to reproduce

  1. Call pull_request_read with method: "get_files" on a PR with more
    than one page of changed files, perPage: 10.
  2. Take any non-empty string as after and call again with the same
    method, perPage: 10, after: "<value>".
  3. Observe: the response is identical to step 1. No error.

Or:

  1. Call with method: "get_review_comments", page: 2.
  2. Observe: page is ignored, first page is returned.

Expected behavior

A pagination parameter that the selected method cannot honour should
produce a validation error naming the method and the parameter, e.g.
method "get_files" uses page/perPage pagination; "after" is not supported. This is consistent with how the tool already rejects an
unknown method.

Why this matters

Silent parameter drops are worst-case for agentic callers: the tool reports
success with a plausible payload, so the model has no reason to retry.
This is the same failure class as #2347 (silent truncation), and a
follow-up to #2489, which added after to the schema but did not add the
guard.

Suggested fix

Before dispatching on method, check whether the caller supplied a
pagination parameter the method doesn't use, and return
utils.NewToolResultError with a clear message. A small helper in
pullrequests.go covers all nine methods.

Happy to open a PR.

Lenguaje dominante
Go
Estrellas
33.1k
Forks
5k
Merge medio
2 d 1 h
PR fusionados (30 d)
25

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de github/github-mcp-server

Todos los issues de github/github-mcp-server

Issues similares

Más issues de Go

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.