Hacktoberfest 2026: as issues que os mantenedores marcaram para outubro, abertas e boas para iniciantes. Ver issues do Hacktoberfest

pull_request_read silently ignores pagination parameters that don't apply to the selected method

Aberta
#3,316 0 comentários 0 reações 0 responsáveis Ver no GitHub

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
3/5
Tempo estimado
1-2 dias
Facilidade para iniciantes
76/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
github, go
Domínio
api, backend

Direção de pesquisa

Start in pullrequests.go at the pull_request_read dispatch and review the existing method validation before dispatching. Use utils.NewToolResultError for unsupported pagination parameters, naming the selected method and parameter; done means mismatched page/perPage or after inputs return clear validation errors instead of being ignored.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Describe the bug

pull_request_read exposes two pagination mechanisms in one schema:

  • page / perPage — used by get_files, get_commits, get_reviews, get_comments, get_check_runs
  • after (cursor) — used only by get_review_comments

When a caller passes a parameter the selected method doesn't use, the
server silently drops it and returns results as if it were never sent.
There is no error, warning, or hint in the response.

The schema description for after does say "used only by the
get_review_comments method", and the code comment confirms other methods
"ignore after" — but for an LLM caller a description is guidance, not
enforcement. The model sees a pagination cursor in the schema, receives a
page of files, and passes after to fetch the next page. It gets the first
page again and has no signal that anything was ignored.

The symmetric case also applies: passing page to get_review_comments
is silently ignored.

Steps to reproduce

  1. Call pull_request_read with method: "get_files" on a PR with more
    than one page of changed files, perPage: 10.
  2. Take any non-empty string as after and call again with the same
    method, perPage: 10, after: "<value>".
  3. Observe: the response is identical to step 1. No error.

Or:

  1. Call with method: "get_review_comments", page: 2.
  2. Observe: page is ignored, first page is returned.

Expected behavior

A pagination parameter that the selected method cannot honour should
produce a validation error naming the method and the parameter, e.g.
method "get_files" uses page/perPage pagination; "after" is not supported. This is consistent with how the tool already rejects an
unknown method.

Why this matters

Silent parameter drops are worst-case for agentic callers: the tool reports
success with a plausible payload, so the model has no reason to retry.
This is the same failure class as #2347 (silent truncation), and a
follow-up to #2489, which added after to the schema but did not add the
guard.

Suggested fix

Before dispatching on method, check whether the caller supplied a
pagination parameter the method doesn't use, and return
utils.NewToolResultError with a clear message. A small helper in
pullrequests.go covers all nine methods.

Happy to open a PR.

Linguagem predominante
Go
Estrelas
33.1k
Forks
5k
Merge médio
2d 3h
PRs com merge (30d)
18

Guia de contribuição

Abrir o guia de contribuição

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de github/github-mcp-server

Todas as issues de github/github-mcp-server

Issues semelhantes

Mais issues de Go

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.