Search by field: state the provider contract, tighten a baseline test and add three tests

Abierto
#3,376 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
48/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
csharp

Línea de trabajo

Start by reading the documentation for SearchRequest.Fields and MatchesByField, then locate IndexesChangedInTheBaseline and the existing field search tests. Add coverage for newly hidden searchable fields, field-limited API keys over HTTP, and rebuild/write cleanup across each provider. Done when the full index line is checked, both docs define null-list behavior, and all three tests pass on every provider.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area:testing plugin type:chore

Follow-ups from the second review of #3357 (#3263), none of which is a leak with the search plugin of the repository:

  • The contract of SearchRequest.Fields for another provider is not written down: a null list means "the searchable fields that are not hidden", not "every row of the index". A provider that indexes hidden or stale fields would return them to an unrestricted caller. State it in the documentation of Fields and of MatchesByField.
  • IndexesChangedInTheBaseline checks only that the line of ux_cms_search_entry_document contains field, then leaves the index out of both catalogs, so a change of its uniqueness or of its other columns would pass. Compare the full expected line.
  • Tests still missing:
    • a stale index row of a field that is searchable and newly hidden does not match (the present test uses a field that was never searchable);
    • a real API key with a field-limited role, over HTTP, cannot match on a hidden field;
    • a rebuild and the next write of an entry delete the rows of a field that is no longer searchable.

Acceptance

  • The documentation of Fields and MatchesByField states what a null list means
  • The baseline test compares the full line of the index
  • The three tests exist and pass on each provider
Lenguaje dominante
C#
Estrellas
567
Forks
107
Merge medio
1 h 19 min
PR fusionados (30 d)
353

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de fluentcms/FluentCMS

Todos los issues de fluentcms/FluentCMS

Issues similares

Más issues de C#

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.