Search by field: state the provider contract, tighten a baseline test and add three tests

Aberta
#3,376 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
48/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
csharp
Domínio
backend, database, testing

Direção de pesquisa

Start by reading the documentation for SearchRequest.Fields and MatchesByField, then locate IndexesChangedInTheBaseline and the existing field search tests. Add coverage for newly hidden searchable fields, field-limited API keys over HTTP, and rebuild/write cleanup across each provider. Done when the full index line is checked, both docs define null-list behavior, and all three tests pass on every provider.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

area:testing plugin type:chore

Follow-ups from the second review of #3357 (#3263), none of which is a leak with the search plugin of the repository:

  • The contract of SearchRequest.Fields for another provider is not written down: a null list means "the searchable fields that are not hidden", not "every row of the index". A provider that indexes hidden or stale fields would return them to an unrestricted caller. State it in the documentation of Fields and of MatchesByField.
  • IndexesChangedInTheBaseline checks only that the line of ux_cms_search_entry_document contains field, then leaves the index out of both catalogs, so a change of its uniqueness or of its other columns would pass. Compare the full expected line.
  • Tests still missing:
    • a stale index row of a field that is searchable and newly hidden does not match (the present test uses a field that was never searchable);
    • a real API key with a field-limited role, over HTTP, cannot match on a hidden field;
    • a rebuild and the next write of an entry delete the rows of a field that is no longer searchable.

Acceptance

  • The documentation of Fields and MatchesByField states what a null list means
  • The baseline test compares the full line of the index
  • The three tests exist and pass on each provider
Linguagem predominante
C#
Estrelas
567
Forks
107
Merge médio
1h 19min
PRs com merge (30d)
353

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de fluentcms/FluentCMS

Todas as issues de fluentcms/FluentCMS

Issues semelhantes

Mais issues de C#

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.