Re-protect secret settings under the current key ring key

Abierto
#3,364 2 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@pournasserian ya está trabajando en esto.

Desde el 20/11/2026.

  • #3433 de @pournasserian — abierto

Evaluación

Dificultad
4/5
Tiempo estimado
1-2 días
Aptitud para principiantes
56/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
csharp
Área
backend, security

Línea de trabajo

Read the SettingsService version check mentioned in the issue and inspect how secret settings are protected and unprotected for each area and scope. Implement a pass that re-protects stored secrets with the current default key and leaves failures untouched, reporting only area and scope. Verify that successful rows unprotect with the current key and that failures do not expose secret values; document the pass as a step before retiring a ring key or certificate.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area:settings security type:feature

Problem

Since #3270 the secret keys of cms_setting.json are protected with Data Protection (fcms-protected:v1: prefix, purpose per area, key and scope). A payload stays bound to the key-ring key that protected it. When the ring rolls to a new key, or the ring certificate is replaced, old rows are only re-protected when an admin happens to write their area. So retiring an old ring key or certificate would make those secrets unreadable. The startup report shows them as settings-secrets-unreadable only once that has already happened.

Proposal

Add a command or job that re-protects every stored secret under the current default key: for each row, unprotect, then write back with the version check SettingsService already uses. It reports rows it cannot unprotect and leaves them untouched. Document it as the step to run before retiring a ring key or certificate.

Acceptance

  • After the pass, every protected secret unprotects with the current default key only
  • Rows it cannot unprotect are left as they are and reported by area and scope, never by value
Lenguaje dominante
C#
Estrellas
567
Forks
107
Merge medio
1 h 19 min
PR fusionados (30 d)
353

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de fluentcms/FluentCMS

Todos los issues de fluentcms/FluentCMS

Issues similares

Más issues de C#

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.