Re-protect secret settings under the current key ring key

Ouverte
#3,364 2 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

@pournasserian y travaille déjà.

Depuis le 20/11/2026.

  • #3433 par @pournasserian — ouverte

Évaluation

Difficulté
4/5
Temps estimé
1-2 jours
Accessibilité débutants
56/100
Type d'issue
Fonctionnalité
Clarté
Plutôt claire
Activité
Active
Stack technique
csharp
Domaine
backend, security

Piste de recherche

Read the SettingsService version check mentioned in the issue and inspect how secret settings are protected and unprotected for each area and scope. Implement a pass that re-protects stored secrets with the current default key and leaves failures untouched, reporting only area and scope. Verify that successful rows unprotect with the current key and that failures do not expose secret values; document the pass as a step before retiring a ring key or certificate.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

area:settings security type:feature

Problem

Since #3270 the secret keys of cms_setting.json are protected with Data Protection (fcms-protected:v1: prefix, purpose per area, key and scope). A payload stays bound to the key-ring key that protected it. When the ring rolls to a new key, or the ring certificate is replaced, old rows are only re-protected when an admin happens to write their area. So retiring an old ring key or certificate would make those secrets unreadable. The startup report shows them as settings-secrets-unreadable only once that has already happened.

Proposal

Add a command or job that re-protects every stored secret under the current default key: for each row, unprotect, then write back with the version check SettingsService already uses. It reports rows it cannot unprotect and leaves them untouched. Document it as the step to run before retiring a ring key or certificate.

Acceptance

  • After the pass, every protected secret unprotects with the current default key only
  • Rows it cannot unprotect are left as they are and reported by area and scope, never by value
Langage dominant
C#
Étoiles
567
Forks
107
Merge moyen
1 h 19 min
PR mergées (30 j)
353

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de fluentcms/FluentCMS

Toutes les issues de fluentcms/FluentCMS

Issues similaires

Plus d'issues C#

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.