Restore has no nuget.config, base images float, and publish ships an image it did not test

Abierto
#3,312 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
35/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
csharp, docker, github-actions
Área
ci-cd, devops, release

Línea de trabajo

Start with the named nuget.config, Dockerfiles, and .github/workflows/publish.yml steps, then review the linked work in #3274 for the digest update proposals. Trace how restore sources, base image digests, smoke testing, and version and channel tags flow through publish. Done means all four acceptance checks pass, including that failed NuGet pushes leave the channel tag unchanged.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area:build security type:chore

Problem

  1. There is no nuget.config. Restore uses whatever sources the machine has, with no package source mapping. The generated configs in eng/fresh-machine.ps1:720-731 and templates/test-templates.sh:41-56 have one.
  2. Dockerfile base images float. src/FluentCMS.Host/Dockerfile:1,7,51 and templates/fluentcms/Dockerfile:1,7,20 use tags, while the compose and test images are pinned by digest.
  3. Publish ships an image it did not test. .github/workflows/publish.yml:254 builds without pushing, :356-358 builds again and pushes, and the Compose smoke test builds a third. A rerun overwrites the :version tag with a different digest.
  4. The channel tag moves before NuGet succeeds. The image, with :latest or :preview, is pushed before the NuGet push; a failed push leaves the channel pointing at a version with no packages.

Proposal

  • A root nuget.config with <clear/>, nuget.org and a * mapping.
  • Pin the base images by digest.
  • Build once, smoke-test that digest, then tag it with docker buildx imagetools create.
  • Push :version first and move the channel tag as the last step.

Done together with #3274, so the pinned digests get update proposals.

Acceptance

  • Restore uses only the sources of the nuget.config in the repository
  • Every FROM names a digest
  • The published image digest is the one the smoke test ran
  • A failed NuGet push leaves the channel tag where it was

Found in the code review of 17 Nov 2026.

Lenguaje dominante
C#
Estrellas
567
Forks
107
Merge medio
1 h 19 min
PR fusionados (30 d)
353

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de fluentcms/FluentCMS

Todos los issues de fluentcms/FluentCMS

Issues similares

Más issues de C#

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.