Restore has no nuget.config, base images float, and publish ships an image it did not test

Aperta
#3,312 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
35/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
csharp, docker, github-actions
Ambito
ci-cd, devops, release

Direzione di ricerca

Start with the named nuget.config, Dockerfiles, and .github/workflows/publish.yml steps, then review the linked work in #3274 for the digest update proposals. Trace how restore sources, base image digests, smoke testing, and version and channel tags flow through publish. Done means all four acceptance checks pass, including that failed NuGet pushes leave the channel tag unchanged.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area:build security type:chore

Problem

  1. There is no nuget.config. Restore uses whatever sources the machine has, with no package source mapping. The generated configs in eng/fresh-machine.ps1:720-731 and templates/test-templates.sh:41-56 have one.
  2. Dockerfile base images float. src/FluentCMS.Host/Dockerfile:1,7,51 and templates/fluentcms/Dockerfile:1,7,20 use tags, while the compose and test images are pinned by digest.
  3. Publish ships an image it did not test. .github/workflows/publish.yml:254 builds without pushing, :356-358 builds again and pushes, and the Compose smoke test builds a third. A rerun overwrites the :version tag with a different digest.
  4. The channel tag moves before NuGet succeeds. The image, with :latest or :preview, is pushed before the NuGet push; a failed push leaves the channel pointing at a version with no packages.

Proposal

  • A root nuget.config with <clear/>, nuget.org and a * mapping.
  • Pin the base images by digest.
  • Build once, smoke-test that digest, then tag it with docker buildx imagetools create.
  • Push :version first and move the channel tag as the last step.

Done together with #3274, so the pinned digests get update proposals.

Acceptance

  • Restore uses only the sources of the nuget.config in the repository
  • Every FROM names a digest
  • The published image digest is the one the smoke test ran
  • A failed NuGet push leaves the channel tag where it was

Found in the code review of 17 Nov 2026.

Lingua principale
C#
Stelle
567
Fork
107
Merge medio
1h 19m
PR unite (30g)
353

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di fluentcms/FluentCMS

Tutte le issue di fluentcms/FluentCMS

Issue simili

Altre issue su C#

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.