Carry the licence and third-party notices in the image and the published admin

Abierto
#3,215 0 comentarios 1 reacción 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
72/100
Tipo de issue
Documentación
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
csharp, docker

Línea de trabajo

Start with src/FluentCMS.Host/Dockerfile, the admin's published wwwroot output, and CONTRIBUTING.md; check how the Compose job validates image contents. Decide where third-party notices are kept, then make sure the image and published admin carry or link LICENSE and THIRD-PARTY-NOTICES.md, and document where future notices go. Done when all three acceptance checks pass.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area:admin area:build type:chore

The admin's QR code encoder (admin/src/FluentCMS.Admin/Account/QrCode.cs, #3147) derives in part from Project Nayuki's QR Code generator, MIT. Its notice is in THIRD-PARTY-NOTICES.md at the repository root and is packed into the FluentCMS.Admin NuGet package. Two places that carry the compiled encoder do not carry the notice:

  • the container image (src/FluentCMS.Host/Dockerfile copies no licence file at all, neither LICENSE nor the notices);
  • the published admin output (wwwroot of the app, as the hosting package and the image serve it).

MIT asks for the notice in all copies or substantial portions.

Expected

The image and the published admin carry LICENSE and THIRD-PARTY-NOTICES.md (a file in the image's application folder; for the admin, a static file next to the app or a link from an About entry, whichever the hosting model makes simple). Decide once where third-party notices go, so the next one has a place.

Acceptance

  • The image holds both files; a test or the Compose job checks they are there.
  • The published admin output holds or links the notices.
  • CONTRIBUTING.md says where a third-party notice goes when code is taken in.

From the review of #3211.

Lenguaje dominante
C#
Estrellas
567
Forks
107
Merge medio
1 h 19 min
PR fusionados (30 d)
353

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de fluentcms/FluentCMS

Todos los issues de fluentcms/FluentCMS

Issues similares

Más issues de C#

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.