Carry the licence and third-party notices in the image and the published admin

Offen
#3,215 0 Kommentare 1 Reaktion 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
72/100
Issue-Typ
Dokumentation
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
csharp, docker

Rechercherichtung

Start with src/FluentCMS.Host/Dockerfile, the admin's published wwwroot output, and CONTRIBUTING.md; check how the Compose job validates image contents. Decide where third-party notices are kept, then make sure the image and published admin carry or link LICENSE and THIRD-PARTY-NOTICES.md, and document where future notices go. Done when all three acceptance checks pass.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

area:admin area:build type:chore

The admin's QR code encoder (admin/src/FluentCMS.Admin/Account/QrCode.cs, #3147) derives in part from Project Nayuki's QR Code generator, MIT. Its notice is in THIRD-PARTY-NOTICES.md at the repository root and is packed into the FluentCMS.Admin NuGet package. Two places that carry the compiled encoder do not carry the notice:

  • the container image (src/FluentCMS.Host/Dockerfile copies no licence file at all, neither LICENSE nor the notices);
  • the published admin output (wwwroot of the app, as the hosting package and the image serve it).

MIT asks for the notice in all copies or substantial portions.

Expected

The image and the published admin carry LICENSE and THIRD-PARTY-NOTICES.md (a file in the image's application folder; for the admin, a static file next to the app or a link from an About entry, whichever the hosting model makes simple). Decide once where third-party notices go, so the next one has a place.

Acceptance

  • The image holds both files; a test or the Compose job checks they are there.
  • The published admin output holds or links the notices.
  • CONTRIBUTING.md says where a third-party notice goes when code is taken in.

From the review of #3211.

Vorherrschende Sprache
C#
Sterne
567
Forks
107
Ø Merge
1 Std. 19 Min.
Gemergte PRs (30 T.)
353

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus fluentcms/FluentCMS

Alle Issues in fluentcms/FluentCMS

Ähnliche Issues

Weitere Issues zu C#

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.