Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Actors: a call cancelled while it runs frees the turn in daprd while the method is still executing, so the next call overlaps (port of dapr/dotnet-sdk#1937)

Abierto
  • ¿Algo no está bien?
#1,346 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 2 días

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
47/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
fastapi, flask, grpc, python
Área
backend, distributed-systems

Línea de trabajo

Start with ActorManager._dispatch_internal and trace how _on_pre_actor_method_internal, the actor method, and _on_post_actor_method_internal run for the same actor ID. Compare the proposed turn-lock behavior with the linked .NET ActorTurnLock and ActorManager; the issue describes the required cancellation and reentrancy cases. Done means actor turns stay serialized through state saving across HTTP and gRPC, including reminders, timers, and deactivation.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Summary

When a caller cancels an actor call while it's running, daprd releases that actor's turn and starts the next queued call, but this SDK keeps running the cancelled call's actor method. Two turns then run on the same actor ID at once, which breaks turn-based concurrency. It happens with reentrancy off as well as on.

The runtime alone can't prevent this. The .NET SDK fixed it on its side in dapr/dotnet-sdk#1937 (released in Dapr.Actors 1.19.0) by holding the turn in the app. This SDK has no equivalent, as far as we can see.

How it happens
  • daprd takes the actor's lock, calls the app with the caller's context, and releases the lock when that call returns (app.InvokeMethod).
  • If the caller cancels, the call to the app returns at once and the lock is released, even though the app is still running the method:
    • Over HTTP, daprd aborts the request.
    • Over the gRPC actor callback stream, daprd stops waiting for the response and sends the app nothing (callbackstream.go).
  • daprd then sends the next queued call for that actor ID. Neither an aborted HTTP request nor an abandoned stream call stops the actor method, so it overlaps with the new call.

dapr/dapr#10835 reported the overlap. dapr/dapr#10842, in runtime 1.19.0, fixed a related case: a call cancelled while still queued no longer evicts the running turn. A cancelled running call still releases the turn early, because daprd can't know when the app finishes once it stops waiting.

Evidence

From the standalone reproduction. Each trial sends 20 calls × 2s to one actor ID, cancels them all at a fixed time, and counts in-progress turns inside the actor. Kubernetes (kind), .NET actor host:

Runtime .NET SDK Reentrancy off Reentrancy on
1.18.7 1.18.10 8 of 12 trials overlapped (up to 7 turns at once) 7 of 12 (up to 9)
1.19.0 1.18.10 (no app-side lock) 3 of 12 (up to 2) 4 of 12 (up to 4)
1.19.0 1.19.0 (with #1937) 0 of 12 0 of 12

We measured this with the .NET SDK only and haven't run the reproduction against this SDK. The code below has no lock that would prevent it, though.

Where (python-sdk)

ActorManager._dispatch_internal holds _active_actors_lock only to look up the actor. _on_pre_actor_method_internal, the method and _on_post_actor_method_internal (the state save) run outside any per-actor lock. Two coroutines for the same actor ID can therefore interleave at any await, over both HTTP (FastAPI/Flask extensions) and the gRPC callback host (grpc_host.py).

Suggested fix

Port the .NET approach: a per-actor turn lock in the SDK (ActorTurnLock, acquired in ActorManager).

  • Acquire it per actor ID before activation and the method call.
  • Hold it until the actor code has finished, including the post-method state save, whether or not the request was cancelled.
  • When reentrancy is enabled, let a call with the same non-empty reentrancy ID as the running turn enter.
  • Apply it to reminders, timers and deactivation as well as method calls.

Its own comment states the rule: "The sidecar can stop waiting before actor code finishes. Keep local ownership until every invocation in the turn has completed, not until its request is cancelled."

Lenguaje dominante
Python
Estrellas
274
Forks
162
Merge medio
2 d 2 h
PR fusionados (30 d)
71

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de dapr/python-sdk

Todos los issues de dapr/python-sdk

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.