Hacktoberfest 2026 : les issues que les mainteneurs ont marquées pour octobre, ouvertes et accessibles aux débutants. Parcourir les issues Hacktoberfest

Actors: a call cancelled while it runs frees the turn in daprd while the method is still executing, so the next call overlaps (port of dapr/dotnet-sdk#1937)

Ouverte
  • Quelque chose ne va pas ?
#1,346 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 2 jours

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
47/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
fastapi, flask, grpc, python
Domaine
backend, distributed-systems

Piste de recherche

Start with ActorManager._dispatch_internal and trace how _on_pre_actor_method_internal, the actor method, and _on_post_actor_method_internal run for the same actor ID. Compare the proposed turn-lock behavior with the linked .NET ActorTurnLock and ActorManager; the issue describes the required cancellation and reentrancy cases. Done means actor turns stay serialized through state saving across HTTP and gRPC, including reminders, timers, and deactivation.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Summary

When a caller cancels an actor call while it's running, daprd releases that actor's turn and starts the next queued call, but this SDK keeps running the cancelled call's actor method. Two turns then run on the same actor ID at once, which breaks turn-based concurrency. It happens with reentrancy off as well as on.

The runtime alone can't prevent this. The .NET SDK fixed it on its side in dapr/dotnet-sdk#1937 (released in Dapr.Actors 1.19.0) by holding the turn in the app. This SDK has no equivalent, as far as we can see.

How it happens
  • daprd takes the actor's lock, calls the app with the caller's context, and releases the lock when that call returns (app.InvokeMethod).
  • If the caller cancels, the call to the app returns at once and the lock is released, even though the app is still running the method:
    • Over HTTP, daprd aborts the request.
    • Over the gRPC actor callback stream, daprd stops waiting for the response and sends the app nothing (callbackstream.go).
  • daprd then sends the next queued call for that actor ID. Neither an aborted HTTP request nor an abandoned stream call stops the actor method, so it overlaps with the new call.

dapr/dapr#10835 reported the overlap. dapr/dapr#10842, in runtime 1.19.0, fixed a related case: a call cancelled while still queued no longer evicts the running turn. A cancelled running call still releases the turn early, because daprd can't know when the app finishes once it stops waiting.

Evidence

From the standalone reproduction. Each trial sends 20 calls × 2s to one actor ID, cancels them all at a fixed time, and counts in-progress turns inside the actor. Kubernetes (kind), .NET actor host:

Runtime .NET SDK Reentrancy off Reentrancy on
1.18.7 1.18.10 8 of 12 trials overlapped (up to 7 turns at once) 7 of 12 (up to 9)
1.19.0 1.18.10 (no app-side lock) 3 of 12 (up to 2) 4 of 12 (up to 4)
1.19.0 1.19.0 (with #1937) 0 of 12 0 of 12

We measured this with the .NET SDK only and haven't run the reproduction against this SDK. The code below has no lock that would prevent it, though.

Where (python-sdk)

ActorManager._dispatch_internal holds _active_actors_lock only to look up the actor. _on_pre_actor_method_internal, the method and _on_post_actor_method_internal (the state save) run outside any per-actor lock. Two coroutines for the same actor ID can therefore interleave at any await, over both HTTP (FastAPI/Flask extensions) and the gRPC callback host (grpc_host.py).

Suggested fix

Port the .NET approach: a per-actor turn lock in the SDK (ActorTurnLock, acquired in ActorManager).

  • Acquire it per actor ID before activation and the method call.
  • Hold it until the actor code has finished, including the post-method state save, whether or not the request was cancelled.
  • When reentrancy is enabled, let a call with the same non-empty reentrancy ID as the running turn enter.
  • Apply it to reminders, timers and deactivation as well as method calls.

Its own comment states the rule: "The sidecar can stop waiting before actor code finishes. Keep local ownership until every invocation in the turn has completed, not until its request is cancelled."

Langage dominant
Python
Étoiles
274
Forks
160
Merge moyen
2 j 2 h
PR mergées (30 j)
71

Préparer son environnement

Ouvrir dans Codespaces

Lance le conteneur de développement du projet dans votre navigateur, avec votre propre compte GitHub.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de dapr/python-sdk

Toutes les issues de dapr/python-sdk

Issues similaires

Plus d'issues Python

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.