Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

feat(hook-manager): add Step P.3b eval suite for hook-manager shim skipping (#1838 follow-up)

Abierto Apto para principiantes
  • ¿Algo no está bien?
#1,891 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@Kaap10 ya está trabajando en esto.

Desde el 28/10/2026.

  • #1892 de @Kaap10 — abierto

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
82/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
python
Área
ai-infra-agents, testing

Línea de trabajo

Empieza con los casos de evaluación en tools/skill-evals/evals/setup-isolated-setup-install/ y las instrucciones del paso P.3b en plugins/magpie-setup/skills/isolated-setup-install/step-p-sandbox-allowlists.md. Añade la suite step-hook-manager-shim para omitir la estrategia none, instalar prek, repositorios mixtos, repositorios no gestionados y el ámbito por proyecto. Ejecuta la suite de evaluación del comportamiento; estará terminada cuando esos casos verifiquen los resultados especificados del dispatcher y del shim instalado.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

What should happen

Add behavioral eval coverage in tools/skill-evals/evals/setup-isolated-setup-install/ for Step P.3b (Step-P prose) verifying that the agent skips copying shims to ~/.claude/bin/ for hook managers whose install strategy is none (simple-git-hooks, cargo-husky, git-code-format-maven-plugin, git-build-hook) and installs the shim exclusively for managers requiring an install fix (prek).

To ensure incremental review and zero external tool dependencies, this follow-up is structured into two parts:

  • Part 1 (Immediate PR): Implement the step-hook-manager-shim behavioral eval suite in setup-isolated-setup-install covering positive, negative (none-strategy skipping), mixed, and scope boundary cases.
  • Part 2 (Subsequent Follow-Up): Empirical execution of git-code-format-maven-plugin and git-build-hook under the whole-user dispatcher in both main checkout and linked worktrees in an environment with JDK 17+ and Maven 3.9+, allowing documentation to drop the "from upstream source" qualifier.
Why

During the review and merge of PR #1838, maintainer @potiuk noted:

"test_none_strategy_generates_no_shim_case pins that the generated shim has no case for a none adapter. The decision that matters is the install step skipping those adapters, which lives in step-p's prose, so its real coverage would be an eval case for setup-isolated-setup-install. A run of the two Maven plugins under the dispatcher, in the main checkout and a linked worktree, would also let those bullets drop the "from upstream source" qualifier."

The generator test test_none_strategy_generates_no_shim_case pins that tools/agent-isolation/hook-manager-shim.sh contains no case statement for none adapters, but does not test the agent's decision-making during Step P.3b execution. Adding an eval suite pins this behavior against regression.

Which layer

Python package (tools/*/ with pyproject.toml)

Boundary conditions (optional)
  • Negative skipping: Repositories using only strategy: "none" adapters (simple-git-hooks, cargo-husky, git-code-format-maven-plugin, git-build-hook) must produce installed_shims: [].
  • Positive installation: Repositories using prek must produce installed_shims: ["prek"].
  • Mixed repositories: Repositories combining prek with none adapters must selectively install installed_shims: ["prek"].
  • Unmanaged repositories: Repositories without hook managers must produce installed_shims: [].
  • Non-dispatcher scopes: When the operator selects per-project scope, Step P.3b must be skipped entirely (dispatcher_installed: false, installed_shims: []).
Out of scope (optional)
  • Modifying tools/hook-manager/registry.json or existing adapter definitions.
  • Running live Java/Maven execution (Part 2).
References (optional)
  • Follow-up from PR #1838 (feat(hook-manager): register managers that need no install fix (#1825))
  • tools/hook-manager/registry.json
  • plugins/magpie-setup/skills/isolated-setup-install/step-p-sandbox-allowlists.md (Step P.3b)
Lenguaje dominante
Python
Estrellas
124
Forks
114
Merge medio
14 h 39 min
PR fusionados (30 d)
370

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de apache/magpie

Todos los issues de apache/magpie

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.