Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

feat(hook-manager): add Step P.3b eval suite for hook-manager shim skipping (#1838 follow-up)

Aperta Adatta ai principianti
  • Qualcosa non va?
#1,891 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@Kaap10 ci sta già lavorando.

Dal 28/10/2026.

  • #1892 di @Kaap10 — aperta

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
82/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
python
Ambito
ai-infra-agents, testing

Direzione di ricerca

Inizia con i casi di valutazione in tools/skill-evals/evals/setup-isolated-setup-install/ e le istruzioni dello Step P.3b in plugins/magpie-setup/skills/isolated-setup-install/step-p-sandbox-allowlists.md. Aggiungi la suite step-hook-manager-shim per l’esclusione con la strategia none, l’installazione di prek, repository misti, repository non gestiti e ambito per progetto. Esegui la suite di valutazione comportamentale; è completata quando questi casi verificano i risultati specificati per il dispatcher e lo shim installato.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

What should happen

Add behavioral eval coverage in tools/skill-evals/evals/setup-isolated-setup-install/ for Step P.3b (Step-P prose) verifying that the agent skips copying shims to ~/.claude/bin/ for hook managers whose install strategy is none (simple-git-hooks, cargo-husky, git-code-format-maven-plugin, git-build-hook) and installs the shim exclusively for managers requiring an install fix (prek).

To ensure incremental review and zero external tool dependencies, this follow-up is structured into two parts:

  • Part 1 (Immediate PR): Implement the step-hook-manager-shim behavioral eval suite in setup-isolated-setup-install covering positive, negative (none-strategy skipping), mixed, and scope boundary cases.
  • Part 2 (Subsequent Follow-Up): Empirical execution of git-code-format-maven-plugin and git-build-hook under the whole-user dispatcher in both main checkout and linked worktrees in an environment with JDK 17+ and Maven 3.9+, allowing documentation to drop the "from upstream source" qualifier.
Why

During the review and merge of PR #1838, maintainer @potiuk noted:

"test_none_strategy_generates_no_shim_case pins that the generated shim has no case for a none adapter. The decision that matters is the install step skipping those adapters, which lives in step-p's prose, so its real coverage would be an eval case for setup-isolated-setup-install. A run of the two Maven plugins under the dispatcher, in the main checkout and a linked worktree, would also let those bullets drop the "from upstream source" qualifier."

The generator test test_none_strategy_generates_no_shim_case pins that tools/agent-isolation/hook-manager-shim.sh contains no case statement for none adapters, but does not test the agent's decision-making during Step P.3b execution. Adding an eval suite pins this behavior against regression.

Which layer

Python package (tools/*/ with pyproject.toml)

Boundary conditions (optional)
  • Negative skipping: Repositories using only strategy: "none" adapters (simple-git-hooks, cargo-husky, git-code-format-maven-plugin, git-build-hook) must produce installed_shims: [].
  • Positive installation: Repositories using prek must produce installed_shims: ["prek"].
  • Mixed repositories: Repositories combining prek with none adapters must selectively install installed_shims: ["prek"].
  • Unmanaged repositories: Repositories without hook managers must produce installed_shims: [].
  • Non-dispatcher scopes: When the operator selects per-project scope, Step P.3b must be skipped entirely (dispatcher_installed: false, installed_shims: []).
Out of scope (optional)
  • Modifying tools/hook-manager/registry.json or existing adapter definitions.
  • Running live Java/Maven execution (Part 2).
References (optional)
  • Follow-up from PR #1838 (feat(hook-manager): register managers that need no install fix (#1825))
  • tools/hook-manager/registry.json
  • plugins/magpie-setup/skills/isolated-setup-install/step-p-sandbox-allowlists.md (Step P.3b)
Lingua principale
Python
Stelle
124
Fork
114
Merge medio
14h 39m
PR unite (30g)
370

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di apache/magpie

Tutte le issue di apache/magpie

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.