[java][Vector][Performance] PromotableWriter.setPosition resolving to itable dispatch on C2 compiled path.
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 45/100
- Tipo de issue
- Nueva funcionalidad
- Claridad
- Bastante claro
- Estado de actividad
- Tranquilo
- Stack tecnológico
- java
- Área
- performance
Línea de trabajo
Empieza con PromotableWriter.setPosition(int) y la ruta de llamadas de AbstractFieldWriter descrita en el issue. Reproduce el comportamiento de dispatch usando el benchmark de JMH en el módulo performance y, a continuación, verifica que el cambio resultante mejora el dispatch medido sin regresiones.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Describe the enhancement requested
This is my first issue report here. Thanks for all the wonderful work.
Usecase: I am planning to replace our parquet-mr based parquet writer with arrow-java to arrow-rs via SharedMemory IPC. Each Kubernetes pod writes about 3 to 4 thousand event per second per pod. The original schema does have some heavy nesting (thrift influence) and schema redesign while desirable but is a much longer exercise. In the process of proof of concept, was able to get the whole flow working but when running some sample shadow flows, saw that all dispatch via
PromotableWriter.setPosition(int index)
would result in a itable dispatch. Looking at it, there could be multiple implementations of FieldWriter's at callsite and C2 fails to convert it into monomorphic or bimorphic calls. Was able to get a synthetic benchmark setup inside the performance module and can see the same in JMH runs too.
This wonderful writeup by Aleksey Shipilev speaks about it in great detail.
We can convert the itable dispatch to a vtable dispatch by the method to be dispatched over AbstractFieldWriter. I will do more tests around the same and can submit the PR here. Tried searching over the issues and this doesn't seem to have been reported so far. Just curious if I am doing something wrong when using ListVector's (and hence holding back attaching the PR straight away!).
Just pasting the screen grab of the actual struct writer used in the benchmark. The benchmark is produced by claude (as one can make it out looking at the comments, but it seemed pretty ok to me).
- Lenguaje dominante
- Java
- Estrellas
- 95
- Forks
- 154
- Merge medio
- 2 d 16 h
- PR fusionados (30 d)
- 9
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de apache/arrow-java
-
Type: bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
apache/arrow-java#1300 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 74/100
apache/arrow-java#1261 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
apache/arrow-java#1236 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
apache/arrow-java#1230 ·
-
Type: bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 85/100
apache/arrow-java#1205 ·
Todos los issues de apache/arrow-java
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
infinispan/infinispan#18150 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
-
untriaged
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
opensearch-project/k-NN#3597 ·
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100